-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle better reconnects #48
Comments
To simulate bad network conditions, this command can be used:
|
The only timer I could think of would be the websocket after 5 seconds. So you have any console and neko logs of a disconnect? |
The logs do not say anything at all. Nor on client or on server (even with debug on). Just that peer connection closed. Websocket is fine, only WebRTC seems to fail. But if that disconnects, then also websocket is reconnected. I've been thinking about implementing ICE Restart (new in pion v3), maybe that could help. |
Testing for some months, number of reconnects dropped to almost zero. Considering this issue as fixed. |
Reconnects are annoying. It happens often with weak/instable connections. After reconnect it works again, however, when watching video you miss 3 - 6 seconds.
Reconnects should be better understood, why they happen and what could be done to prevent them. Since I watch video without any visible problems, and after reconnect that video works again, network must be good enough. Maybe some timers are there, that expire or kick user out in some weird edge case scenarios.
Temporary network problems should be handled gracefully. If possible (in Pion).
The text was updated successfully, but these errors were encountered: