PR comments

src/dbnode/integration/bootstrap_retries_test.go

@@ -61,7 +61,7 @@ func TestBootstrapRetriesDueToError(t *testing.T) {
 	})
 
 	go func() {
-		// Wait for server to start
+		// Wait for server to get started by the main test method.
 		setup.WaitUntilServerIsUp()
 
 		// First bootstrap pass. Bootstrapper produces an error. Check if DB is not marked bootstrapped.
@@ -105,7 +105,7 @@ func TestBootstrapRetriesDueToObsoleteRanges(t *testing.T) {
 	})
 
 	go func() {
-		// Wait for server to start
+		// Wait for server to get started by the main test method.
 		setup.WaitUntilServerIsUp()
 
 		// First bootstrap pass, persist ranges. Check if DB is not marked bootstrapped.
@@ -158,7 +158,7 @@ func TestBootstrapRetriesDueToUnfulfilledRanges(t *testing.T) {
 	})
 
 	go func() {
-		// Wait for server to start
+		// Wait for server to get started by the main test method.
 		setup.WaitUntilServerIsUp()
 
 		// First bootstrap pass. Bootstrap produces unfulfilled ranges for persist range.

src/dbnode/storage/bootstrap_instrumentation_test.go

@@ -79,11 +79,11 @@ func getBootstrapRetryMetrics(testScope tally.TestScope) map[string]int {
 	valuesByReason := make(map[string]int)
 	for _, counter := range testScope.Snapshot().Counters() {
 		if strings.Contains(counter.Name(), metricName) {
+			reason := ""
 			if r, ok := counter.Tags()[reasonTag]; ok {
-				valuesByReason[r] = int(counter.Value())
-			} else {
-				valuesByReason[""] = int(counter.Value())
+				reason = r
 			}
+			valuesByReason[reason] = int(counter.Value())
 		}
 	}
 	return valuesByReason