Address PR feedback

m3db · Oct 6, 2021 · 4c5005f · 4c5005f
1 parent 0a65bd3
commit 4c5005f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/dbnode/storage/entry.go b/src/dbnode/storage/entry.go
@@ -142,13 +142,13 @@ func (entry *Entry) IndexedForBlockStart(indexBlockStart xtime.UnixNano) bool {
 }
 
 // IndexedRange returns minimum and maximum blockStart values covered by index entry.
-// Note that there may be uncovered gaps within that range.
+// The range is inclusive. Note that there may be uncovered gaps within the range.
 // Returns (0, 0) for an empty range.
 func (entry *Entry) IndexedRange() (xtime.UnixNano, xtime.UnixNano) {
 	entry.reverseIndex.RLock()
-	defer entry.reverseIndex.RUnlock()
-
-	return entry.reverseIndex.indexedRangeWithRLock()
+	min, max := entry.reverseIndex.indexedRangeWithRLock()
+	entry.reverseIndex.RUnlock()
+	return min, max
 }
 
 // NeedsIndexUpdate returns a bool to indicate if the Entry needs to be indexed

diff --git a/src/m3ninx/doc/types.go b/src/m3ninx/doc/types.go
@@ -126,7 +126,7 @@ type OnIndexSeries interface {
 	IndexedForBlockStart(blockStart xtime.UnixNano) bool
 
 	// IndexedRange returns minimum and maximum blockStart values covered by index entry.
-	// Note that there may be uncovered gaps within that range.
+	// The range is inclusive. Note that there may be uncovered gaps within the range.
 	// Returns (0, 0) for an empty range.
 	IndexedRange() (xtime.UnixNano, xtime.UnixNano)
 }