Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coordinator] Disable downsampler matcher cache by default #3080

Merged
merged 2 commits into from
Jan 13, 2021
Merged

[coordinator] Disable downsampler matcher cache by default #3080

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8633d
[coordinator] Disable downsampler matcher cache by default
robskillington Jan 12, 2021
decd9b6
Merge branch 'master' into r/matcher-cache-off-by-default
robskillington Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/cmd/services/m3coordinator/downsample/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,13 @@ const (
defaultOpenTimeout = 10 * time.Second
defaultBufferFutureTimedMetric = time.Minute
defaultVerboseErrors = true
defaultMatcherCacheCapacity = 100000
// defaultMatcherCacheCapacity sets the default matcher cache
// capacity to zero so that the cache is turned off.
// This is due to discovering that there is a lot of contention
// used by the cache and the fact that most coordinators are used
// in a stateless manner with a central deployment which in turn
// leads to an extremely low cache hit ratio anyway.
defaultMatcherCacheCapacity = 0
)

var (
Expand Down Expand Up @@ -537,7 +543,7 @@ func (r RollupRuleConfiguration) Rule() (view.RollupRule, error) {
targetPipeline := pipeline.NewPipeline(ops)

targets := []view.RollupTarget{
view.RollupTarget{
{
Pipeline: targetPipeline,
StoragePolicies: storagePolicies,
},
Expand Down