[m3db] [m3coordinator] Properly pipe along require-exhaustive param for aggregate queries #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or aggregate queries
nbroyles
reviewed
Jan 22, 2021
| @@ -432,6 +433,7 @@ struct AggregateQueryRequest { | |||
| 8: optional TimeType rangeType = TimeType.UNIX_SECONDS | |||
| 9: optional binary source | |||
| 10: optional i64 docsLimit | |||
| 11: optional bool requireExhaustive | |||
There was a problem hiding this comment.
Does this indicate that the results are exhaustive or whether you passed the flag in in the first place? If it's the former, let's just call it exhaustive
There was a problem hiding this comment.
it's on the request side, saying it requires the results to be exhaustive. Would rather stick with that as it's how our other requests use it.
There was a problem hiding this comment.
Oh wait, my bad, this is a request. Not a result. Misread the struct
nbroyles
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
[m3db] [m3coordinator] Properly pipe along require-exhaustive param for aggregate queries
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE
Does this PR require updating code package or user-facing documentation?:
NONE