Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[donode] Fix Data Race in checkoutSeriesWithLock during TestReadNilTimeRanges #3300

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[donode] Fix Data Race in checkoutSeriesWithLock during TestReadNilTimeRanges #3300

merged 2 commits into from
Mar 2, 2021

Conversation

miroswan
Copy link
Contributor

What this PR does / why we need it:

Fixes #3299

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #3300 (7bf92e8) into master (da44ea0) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3300   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1099     1099           
  Lines      101504   101506    +2     
=======================================
+ Hits        73579    73582    +3     
- Misses      22849    22854    +5     
+ Partials     5076     5070    -6
Flag Coverage Δ
aggregator 76.4% <ø> (-0.1%) ⬇️
cluster 84.9% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.9% <100.0%> (+<0.1%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.6% <ø> (+<0.1%) ⬆️
metrics 19.9% <ø> (ø)
msg 74.1% <ø> (-0.2%) ⬇️
query 67.3% <ø> (ø)
x 80.5% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da44ea0...7bf92e8. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2021 •
edited
Loading

Codecov Report

Merging #3300 (1a26bf5) into master (1a26bf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3300   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1099     1099           
  Lines      101522   101522           
=======================================
  Hits        73589    73589           
  Misses      22846    22846           
  Partials     5087     5087
Flag Coverage Δ
aggregator 76.4% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 78.8% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.9% <0.0%> (ø)
msg 73.9% <0.0%> (ø)
query 67.4% <0.0%> (ø)
x 80.5% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a26bf5...1857d0a. Read the comment docs.

@miroswan
Copy link
Contributor Author

miroswan commented Mar 1, 2021

It looks like this build is failing due to code coverage issues for seemingly unrelated packages. LMK what you'd like to do to move forward.

wesleyk
wesleyk approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@wesleyk wesleyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miroswan miroswan mentioned this pull request Mar 2, 2021
Merged
@wesleyk wesleyk merged commit a997c83 into m3db:master Mar 2, 2021
soundvibe added a commit that referenced this pull request Mar 3, 2021
@soundvibe
Merge branch 'master' into linasn/series-resolver
34e85db 
* master:
  [aggregator] Move placement checks to a background job (#3315)
  [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314)
  [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310)
  Update server.go (#3298)
  Fix Data Race in checkoutSeriesWithLock (#3300)
  [query] Allow configuration of placement options (#3304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyk wesleyk wesleyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TestReadNilTimeRanges
2 participants
@miroswan @wesleyk