Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbnode] Series ref resolver #3316

Merged
merged 38 commits into from
Mar 15, 2021
Merged

[dbnode] Series ref resolver #3316

Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
0777cc4
WIP [dbnode] Use series read write ref resolver
robskillington Mar 2, 2021
fa01bbb
fixing the build and making unit tests pass.
soundvibe Mar 3, 2021
34e85db
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 3, 2021
1385c2f
trying to fix resolve error.
soundvibe Mar 3, 2021
9cc2a22
trying to fix resolve error (2).
soundvibe Mar 3, 2021
8c02b88
trying to fix resolve error (3).
soundvibe Mar 3, 2021
48fdcf8
add logging to check if series was expired.
soundvibe Mar 4, 2021
537823a
try incrementing reader-writer count for a new entry so it won't be p…
soundvibe Mar 4, 2021
abf5160
handle accumulator close errors.
soundvibe Mar 5, 2021
ef4d08d
test commit with warm flush and seriesId cache.
soundvibe Mar 5, 2021
87979c8
trying to fix warm flush.
soundvibe Mar 5, 2021
b404219
revert flush changes.
soundvibe Mar 5, 2021
acc2f0a
use multiErrors.
soundvibe Mar 5, 2021
c0877e8
fixed index write when using series ref.
soundvibe Mar 8, 2021
80f4e42
insert new entry and inc ref count.
soundvibe Mar 8, 2021
b481a6c
fixed linter issues.
soundvibe Mar 8, 2021
6078828
small cleanup.
soundvibe Mar 8, 2021
2f5f2c8
optimized series ref resolver usage.
soundvibe Mar 9, 2021
05bec35
added unit test.
soundvibe Mar 9, 2021
629efb9
fixing possible race.
soundvibe Mar 9, 2021
28caa33
simplified error handling in commit log bs.
soundvibe Mar 9, 2021
a892422
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 9, 2021
79343ed
use cancellable context to cancel read series goroutine if load block…
soundvibe Mar 10, 2021
b26825f
load blocks concurrently.
soundvibe Mar 10, 2021
0658b1d
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 10, 2021
51ed40f
changes after review.
soundvibe Mar 10, 2021
be6604b
removed previously added logging line for testing.
soundvibe Mar 10, 2021
baeca8d
updated mocks.
soundvibe Mar 10, 2021
d3c69cf
updated some code comments.
soundvibe Mar 10, 2021
2d14706
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 10, 2021
bfc972a
renamed entryRefCountIncremented option to releaseEntryRef.
soundvibe Mar 10, 2021
15b82e1
extracted series resolver into separate file.
soundvibe Mar 15, 2021
49561ad
check if context was not cancelled once in 1024 iterations instead of…
soundvibe Mar 15, 2021
e6fbdf5
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 15, 2021
2d2fc76
fixed comment.
soundvibe Mar 15, 2021
4489d21
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 15, 2021
49f9753
inline retrieveWritableSeries function into series resolver.
soundvibe Mar 15, 2021
535e786
Merge branch 'master' into linasn/series-resolver
soundvibe Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dbnode/generated/mocks/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
//go:generate sh -c "mockgen -package=xio $PACKAGE/src/dbnode/x/xio SegmentReader,SegmentReaderPool | genclean -pkg $PACKAGE/src/dbnode/x/xio -out $GOPATH/src/$PACKAGE/src/dbnode/x/xio/io_mock.go"
//go:generate sh -c "mockgen -package=digest -destination=$GOPATH/src/$PACKAGE/src/dbnode/digest/digest_mock.go $PACKAGE/src/dbnode/digest ReaderWithDigest"
//go:generate sh -c "mockgen -package=series $PACKAGE/src/dbnode/storage/series DatabaseSeries,QueryableBlockRetriever | genclean -pkg $PACKAGE/src/dbnode/storage/series -out $GOPATH/src/$PACKAGE/src/dbnode/storage/series/series_mock.go"
//go:generate sh -c "mockgen -package=lookup $PACKAGE/src/dbnode/storage/series/lookup OnReleaseReadWriteRef,IndexWriter | genclean -pkg $PACKAGE/src/dbnode/storage/series/lookup -out $GOPATH/src/$PACKAGE/src/dbnode/storage/series/lookup/lookup_mock.go"
//go:generate sh -c "mockgen -package=lookup $PACKAGE/src/dbnode/storage/series/lookup IndexWriter | genclean -pkg $PACKAGE/src/dbnode/storage/series/lookup -out $GOPATH/src/$PACKAGE/src/dbnode/storage/series/lookup/lookup_mock.go"

// mockgen rules for generating mocks for unexported interfaces (file mode)
//go:generate sh -c "mockgen -package=encoding -destination=$GOPATH/src/$PACKAGE/src/dbnode/encoding/encoding_mock.go -source=$GOPATH/src/$PACKAGE/src/dbnode/encoding/types.go"
Expand Down
68 changes: 67 additions & 1 deletion src/dbnode/storage/bootstrap/bootstrap_mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading