Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtest] ns update/delete api #3344

Merged
merged 6 commits into from
Mar 10, 2021
Merged

[dtest] ns update/delete api #3344

merged 6 commits into from
Mar 10, 2021

Conversation

gediminasgu
Copy link
Collaborator

What this PR does / why we need it:
Adds namespace update/delete methods to test API to allow us to change namespace settings during the test.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@gediminasgu gediminasgu requested a review from linasm March 9, 2021 12:23
Copy link
Collaborator

@linasm linasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits inline.

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #3344 (8ece790) into master (8ece790) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3344   +/-   ##
=======================================
  Coverage    72.6%    72.6%           
=======================================
  Files        1098     1098           
  Lines      103388   103388           
=======================================
  Hits        75096    75096           
  Misses      23145    23145           
  Partials     5147     5147           
Flag Coverage Δ
aggregator 76.8% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 79.0% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.5% <0.0%> (ø)
query 67.3% <0.0%> (ø)
x 80.5% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ece790...71aab3b. Read the comment docs.

@gediminasgu gediminasgu merged commit e103a67 into master Mar 10, 2021
@gediminasgu gediminasgu deleted the gg/dtest-ns-updatedelete branch March 10, 2021 10:56
soundvibe added a commit that referenced this pull request Mar 10, 2021
* master:
  [dtest] ns update/delete api (#3344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants