Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Update Graphite find calls to complete unterminated queries with all possible path values for ** #3593

Merged
merged 10 commits into from
Jul 12, 2021

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Previously find calls did not special case ** and such were looking for terminated and unterminated queries for fields that had any value for the first graphite path index (since matchers created for ** are special and regex against the whole timeseries ID, they cannot be treated this way and need to complete all values for all possible path indexes).

This special cases the ** case and completes tag values for all of the path indexes that could be possibly relevant to the find query.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@robskillington robskillington enabled auto-merge (squash) July 12, 2021 04:51
Copy link
Collaborator

@linasm linasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much of a context for this code, but one part of the implementation looks somewhat suspicious (see the comments inline),.

src/query/graphite/storage/m3_wrapper.go Outdated Show resolved Hide resolved
src/query/api/v1/handler/graphite/find_parser.go Outdated Show resolved Hide resolved
src/query/api/v1/handler/graphite/find.go Show resolved Hide resolved
src/query/api/v1/handler/graphite/find.go Show resolved Hide resolved
Copy link
Collaborator

@wesleyk wesleyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit b992a1e into master Jul 12, 2021
@robskillington robskillington deleted the r/fix-find-star-star-query-completions branch July 12, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants