Removed CLS compliance. (#1057)

* Removed CLSCompliance attribute from ILGPU. * Removed CLSCompliance attribute from ILGPU.Algorithms. * Removed CLSCompliance attribute from Tests.
m4rs-mt · Aug 29, 2023 · 9ddca0b · 9ddca0b
1 parent 976f621
commit 9ddca0b
Show file tree

Hide file tree

Showing 63 changed files with 60 additions and 293 deletions.
diff --git a/Src/ILGPU.Algorithms/AssemblyAttributes.cs b/Src/ILGPU.Algorithms/AssemblyAttributes.cs
@@ -1,5 +1,4 @@
 using System;
 using System.Runtime.CompilerServices;
 
-[assembly: CLSCompliant(true)]
 [assembly: InternalsVisibleTo(ILGPU.Context.RuntimeAssemblyName)]
diff --git a/Src/ILGPU.Algorithms/ComparisonOperations.tt b/Src/ILGPU.Algorithms/ComparisonOperations.tt
@@ -1,6 +1,6 @@
 // ---------------------------------------------------------------------------------------
 //                                   ILGPU Algorithms
-//                        Copyright (c) 2020-2021 ILGPU Project
+//                        Copyright (c) 2020-2023 ILGPU Project
 //                                    www.ilgpu.net
 //
 // File: ComparisonOperations.tt/ComparisonOperations.cs
@@ -27,9 +27,6 @@ namespace ILGPU.Algorithms.ComparisonOperations
     /// <summary>
     /// Represents an comparison between two elements of type <#= type.Type #>.
     /// </summary>
-<#      if (!type.IsCLSCompliant) { #>
-    [CLSCompliant(false)]
-<#      } #>
     public readonly struct Comparison<#= type.Name #>
         : IComparisonOperation<<#= type.Type #>>
     {

diff --git a/Src/ILGPU.Algorithms/HistogramLaunchers.tt b/Src/ILGPU.Algorithms/HistogramLaunchers.tt
@@ -49,9 +49,6 @@ namespace ILGPU.Algorithms
         /// <param name="histogramOverflow">
         /// Single-element view that indicates whether the histogram has overflowed.
         /// </param>
-<# if (!type.IsCLSCompliant) { #>
-        [CLSCompliant(false)]
-<# } #>
         public static void Histogram<T, TStride, TLocator>(
             this Accelerator accelerator,
             AcceleratorStream stream,

diff --git a/Src/ILGPU.Algorithms/HistogramOperations.tt b/Src/ILGPU.Algorithms/HistogramOperations.tt
@@ -1,6 +1,6 @@
 // ---------------------------------------------------------------------------------------
 //                                   ILGPU Algorithms
-//                        Copyright (c) 2020-2021 ILGPU Project
+//                        Copyright (c) 2020-2023 ILGPU Project
 //                                    www.ilgpu.net
 //
 // File: HistogramOperations.tt/HistogramOperations.cs
@@ -27,9 +27,6 @@ namespace ILGPU.Algorithms.HistogramOperations
     /// <summary>
     /// Represents atomically incrementing a histogram bin of type <#= type.Type #>.
     /// </summary>
-<# if (!type.IsCLSCompliant) { #>
-    [CLSCompliant(false)]
-<# } #>
     public readonly struct HistogramIncrement<#= type.Name #> :
         IIncrementOperation<<#= type.Type #>>
     {

diff --git a/Src/ILGPU.Algorithms/Optimization/Optimizers/PSO.cs b/Src/ILGPU.Algorithms/Optimization/Optimizers/PSO.cs
@@ -28,12 +28,12 @@ public static class PSO
         /// A common choice for Omega.
         /// </summary>
         public const float Omega  = 0.8f;
-        
+
         /// <summary>
         /// A common choice for PhiG.
         /// </summary>
         public const float PhiG = 1.5f;
-        
+
         /// <summary>
         /// A common choice for PhiP.
         /// </summary>
@@ -52,7 +52,7 @@ public static class PSO
         /// </summary>
         public static ReadOnlySpan<float> DefaultFloatParameters => FloatParameters;
     }
-    
+
     /// <summary>
     /// Represents a particle-swap optimization engine (PSO) that uses a PSO algorithm
     /// to solve n-dimensional optimization problems.
@@ -61,7 +61,6 @@ public static class PSO
     /// <typeparam name="TElementType">The element type of a numeric type.</typeparam>
     /// <typeparam name="TEvalType">The evaluation data type.</typeparam>
     /// <typeparam name="TRandomProvider">The RNG type.</typeparam>
-    [CLSCompliant(false)]
     public sealed class PSO<TNumericType, TElementType, TEvalType, TRandomProvider>
         : OptimizationEngine<TNumericType, TElementType, TEvalType>
         where TNumericType : unmanaged, IVectorType<TNumericType, TElementType>
@@ -73,10 +72,10 @@ public sealed class PSO<TNumericType, TElementType, TEvalType, TRandomProvider>
         private const int ParameterOmega = 0;
         private const int ParameterPhiP = 1;
         private const int ParameterPhiG = 2;
-        
+
         private readonly MemoryBuffer2D<TNumericType, Stride2D.DenseY> velocities;
         private readonly MemoryBuffer2D<TNumericType, Stride2D.DenseY> bestPositions;
-        
+
         /// <summary>
         /// Creates a new PS engine.
         /// </summary>
@@ -108,7 +107,7 @@ public PSO(
                 bestPositions.View,
                 EvaluationsView);
         }
-        
+
         /// <summary>
         /// Returns a PSO-specific data view.
         /// </summary>
@@ -122,7 +121,7 @@ public TElementType Omega
             get => GetParameter(ParameterOmega);
             set => GetParameter(ParameterOmega) = value;
         }
-        
+
         /// <summary>
         /// Gets or sets the phi p velocity parameter.
         /// </summary>
@@ -131,7 +130,7 @@ public TElementType PhiP
             get => GetParameter(ParameterPhiP);
             set => GetParameter(ParameterPhiP) = value;
         }
-        
+
         /// <summary>
         /// Gets or sets the phi g velocity parameter.
         /// </summary>

diff --git a/Src/ILGPU.Algorithms/RadixSortOperations.tt b/Src/ILGPU.Algorithms/RadixSortOperations.tt
@@ -1,6 +1,6 @@
 // ---------------------------------------------------------------------------------------
 //                                   ILGPU Algorithms
-//                        Copyright (c) 2019-2021 ILGPU Project
+//                        Copyright (c) 2019-2023 ILGPU Project
 //                                    www.ilgpu.net
 //
 // File: RadixSortOperations.tt/RadixSortOperations.cs
@@ -27,9 +27,6 @@ namespace ILGPU.Algorithms.RadixSortOperations
     /// <summary>
     /// Represents an ascending radix sort operation of type <#= type.Type #>.
     /// </summary>
-<#      if (!type.IsCLSCompliant) { #>
-    [CLSCompliant(false)]
-<#      } #>
     public readonly struct Ascending<#=type.Name #> :
         IRadixSortOperation<<#= type.Type #>>
     {
@@ -100,9 +97,6 @@ namespace ILGPU.Algorithms.RadixSortOperations
     /// <summary>
     /// Represents a descending radix sort operation of type <#= type.Type #>.
     /// </summary>
-<#      if (!type.IsCLSCompliant) { #>
-    [CLSCompliant(false)]
-<#      } #>
     public readonly struct Descending<#= type.Name #> :
         IRadixSortOperation<<#= type.Type #>>
     {

diff --git a/Src/ILGPU.Algorithms/Random/IRandomProvider.cs b/Src/ILGPU.Algorithms/Random/IRandomProvider.cs
@@ -53,7 +53,6 @@ public interface IRandomProvider
     /// An abstract RNG provider that supports period shifts.
     /// </summary>
     /// <typeparam name="TProvider">The implementing provider type.</typeparam>
-    [CLSCompliant(false)]
     public interface IRandomProvider<TProvider> : IRandomProvider
         where TProvider : struct, IRandomProvider<TProvider>
     {

diff --git a/Src/ILGPU.Algorithms/Random/RNG.cs b/Src/ILGPU.Algorithms/Random/RNG.cs
@@ -31,7 +31,6 @@ public abstract class RNG : AcceleratorObject
         /// <typeparam name="TRandomProvider">The random provider type.</typeparam>
         /// <param name="accelerator">The current accelerator.</param>
         /// <param name="random">The parent RNG provider.</param>
-        [CLSCompliant(false)]
         public static RNG<TRandomProvider> Create<TRandomProvider>(
             Accelerator accelerator,
             System.Random random)
@@ -47,7 +46,6 @@ public static RNG<TRandomProvider> Create<TRandomProvider>(
         /// <param name="maxNumParallelWarps">
         /// The maximum number of parallel warps.
         /// </param>
-        [CLSCompliant(false)]
         public static RNG<TRandomProvider> Create<TRandomProvider>(
             Accelerator accelerator,
             System.Random random,
@@ -148,7 +146,6 @@ public abstract void FillUniform(
     /// is stored within an underlying memory buffer.
     /// </summary>
     /// <typeparam name="TRandomProvider">The random provider type.</typeparam>
-    [CLSCompliant(false)]
     public readonly struct RNGView<TRandomProvider> : IRandomProvider
         where TRandomProvider : unmanaged, IRandomProvider<TRandomProvider>
     {
@@ -259,7 +256,6 @@ public readonly double NextDouble() =>
     /// </summary>
     /// <typeparam name="TRandomProvider">The random provider type.</typeparam>
     /// <remarks>Members of this class are not thread safe.</remarks>
-    [CLSCompliant(false)]
     public class RNG<TRandomProvider> : RNG
         where TRandomProvider : unmanaged, IRandomProvider<TRandomProvider>
     {

diff --git a/Src/ILGPU.Algorithms/Random/RandomExtensions.cs b/Src/ILGPU.Algorithms/Random/RandomExtensions.cs
@@ -180,7 +180,6 @@ public static long Next<TRandomProvider>(
         /// <typeparam name="TRandomProvider">The random provider type.</typeparam>
         /// <param name="accelerator">The current accelerator.</param>
         /// <param name="random">The parent RNG provider.</param>
-        [CLSCompliant(false)]
         public static RNG<TRandomProvider> CreateRNG<TRandomProvider>(
             this Accelerator accelerator,
             System.Random random)
@@ -196,7 +195,6 @@ public static RNG<TRandomProvider> CreateRNG<TRandomProvider>(
         /// <param name="maxNumParallelWarps">
         /// The maximum number of parallel warps.
         /// </param>
-        [CLSCompliant(false)]
         public static RNG<TRandomProvider> CreateRNG<TRandomProvider>(
             this Accelerator accelerator,
             System.Random random,
@@ -220,7 +218,7 @@ internal static void InitializeRNGKernel<TRandomProvider>(
             {
                 randomProvider[i] = default(TRandomProvider).CreateProvider(ref provider);
             }
-            
+
             // Update provider state for future iterations
             sourceProviders[index] = provider;
         }
@@ -236,7 +234,6 @@ internal static void InitializeRNGKernel<TRandomProvider>(
         /// <param name="rngView">The view to fill.</param>
         /// <param name="random">The source RNG provider.</param>
         /// <param name="numInitializers">The number of CPU initializers to use.</param>
-        [CLSCompliant(false)]
         public static void InitRNGView<TRandomProvider>(
             this Accelerator accelerator,
             AcceleratorStream stream,

diff --git a/Src/ILGPU.Algorithms/Random/ThreadWiseRNG.cs b/Src/ILGPU.Algorithms/Random/ThreadWiseRNG.cs
@@ -19,17 +19,16 @@ namespace ILGPU.Algorithms.Random
     /// Represents a single RNG instance per thread stored separately in a memory buffer.
     /// </summary>
     /// <typeparam name="TRandomProvider">The underlying RNG provider type.</typeparam>
-    [CLSCompliant(false)]
     public class ThreadWiseRNG<TRandomProvider> : DisposeBase
         where TRandomProvider : unmanaged, IRandomProvider<TRandomProvider>
     {
         #region Instance
-        
+
         /// <summary>
         /// Stores a single RNG instance per thread.
         /// </summary>
         private readonly MemoryBuffer1D<TRandomProvider, Stride1D.Dense> randomProviders;
-        
+
         /// <summary>
         /// Constructs an RNG using the given provider instance.
         /// </summary>
@@ -54,9 +53,9 @@ public ThreadWiseRNG(
             randomProviders = accelerator.Allocate1D<TRandomProvider>(maxNumThreads);
             accelerator.InitRNGView(stream, RNGView, random, numInitializers);
         }
-        
+
         #endregion
-        
+
         #region Methods
 
         /// <summary>
@@ -65,7 +64,7 @@ public ThreadWiseRNG(
         public ArrayView<TRandomProvider> RNGView => randomProviders.View;
 
         #endregion
-        
+
         #region IDisposable
 
         /// <summary>

diff --git a/Src/ILGPU.Algorithms/Random/XorShift128.cs b/Src/ILGPU.Algorithms/Random/XorShift128.cs
@@ -20,7 +20,6 @@ namespace ILGPU.Algorithms.Random
     /// Implements a simple and fast xor-shift rng.
     /// </summary>
     /// <remarks>https://en.wikipedia.org/wiki/Xorshift</remarks>
-    [CLSCompliant(false)]
     public struct XorShift128 : IEquatable<XorShift128>, IRandomProvider<XorShift128>
     {
         #region Static

diff --git a/Src/ILGPU.Algorithms/Random/XorShift128Plus.cs b/Src/ILGPU.Algorithms/Random/XorShift128Plus.cs
@@ -20,7 +20,6 @@ namespace ILGPU.Algorithms.Random
     /// Implements a simple and fast xor-shift rng.
     /// </summary>
     /// <remarks>https://en.wikipedia.org/wiki/Xorshift</remarks>
-    [CLSCompliant(false)]
     public struct XorShift128Plus :
         IEquatable<XorShift128Plus>,
         IRandomProvider<XorShift128Plus>

diff --git a/Src/ILGPU.Algorithms/Random/XorShift32.cs b/Src/ILGPU.Algorithms/Random/XorShift32.cs
@@ -20,7 +20,6 @@ namespace ILGPU.Algorithms.Random
     /// Implements a simple and fast xor-shift rng.
     /// </summary>
     /// <remarks>https://en.wikipedia.org/wiki/Xorshift</remarks>
-    [CLSCompliant(false)]
     public struct XorShift32 : IEquatable<XorShift32>, IRandomProvider<XorShift32>
     {
         #region Static

diff --git a/Src/ILGPU.Algorithms/Random/XorShift64Star.cs b/Src/ILGPU.Algorithms/Random/XorShift64Star.cs
@@ -20,7 +20,6 @@ namespace ILGPU.Algorithms.Random
     /// Implements a simple and fast xor-shift rng.
     /// </summary>
     /// <remarks>https://en.wikipedia.org/wiki/Xorshift</remarks>
-    [CLSCompliant(false)]
     public struct XorShift64Star :
         IEquatable<XorShift64Star>,
         IRandomProvider<XorShift64Star>

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/API/CuFFTAPI.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/API/CuFFTAPI.cs
@@ -18,7 +18,6 @@ namespace ILGPU.Runtime.Cuda.API
     /// <summary>
     /// An implementation of the cuFFT API.
     /// </summary>
-    [CLSCompliant(false)]
     public abstract partial class CuFFTAPI
     {
         #region Static

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/API/CuFFTWAPI.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/API/CuFFTWAPI.cs
@@ -16,7 +16,6 @@ namespace ILGPU.Runtime.Cuda.API
     /// <summary>
     /// An implementation of the cuFFT API.
     /// </summary>
-    [CLSCompliant(false)]
     public abstract partial class CuFFTWAPI
     {
         #region Static

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/API/NvJpegAPI.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/API/NvJpegAPI.cs
@@ -16,7 +16,6 @@ namespace ILGPU.Runtime.Cuda.API
     /// <summary>
     /// An implementation of the nvJpeg API.
     /// </summary>
-    [CLSCompliant(false)]
     public abstract partial class NvJpegAPI
     {
         #region Static

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/API/NvmlAPI.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/API/NvmlAPI.cs
@@ -20,7 +20,6 @@ namespace ILGPU.Runtime.Cuda.API
     /// <summary>
     /// An implementation of the NVML API.
     /// </summary>
-    [CLSCompliant(false)]
     public abstract partial class NvmlAPI
     {
         #region Static
@@ -281,7 +280,6 @@ public unsafe NvmlReturn DeviceGetBoardPartNumber(
         /// Provides access to <see cref="DeviceGetBridgeChipInfo_Interop"/>
         /// without using raw pointers.
         /// </summary>
-        [CLSCompliant(false)]
         public unsafe NvmlReturn DeviceGetBridgeChipInfo(
             IntPtr device,
             out NvmlBridgeChipHierarchy bridgeHierarchy)

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFT.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFT.cs
@@ -17,7 +17,6 @@ namespace ILGPU.Runtime.Cuda
     /// <summary>
     /// Wrapper over cuFFT to simplify integration with ILGPU.
     /// </summary>
-    [CLSCompliant(false)]
     public sealed class CuFFT
     {
         /// <summary>

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFTPlan.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFTPlan.cs
@@ -1,6 +1,6 @@
 // ---------------------------------------------------------------------------------------
 //                                   ILGPU Algorithms
-//                           Copyright (c) 2021 ILGPU Project
+//                        Copyright (c) 2021-2023 ILGPU Project
 //                                    www.ilgpu.net
 //
 // File: CuFFTPlan.cs
@@ -18,7 +18,6 @@ namespace ILGPU.Runtime.Cuda
     /// <summary>
     /// Represents a cuFFT plan.
     /// </summary>
-    [CLSCompliant(false)]
     public sealed partial class CuFFTPlan : DisposeBase
     {
         /// <summary>

diff --git a/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFTW.cs b/Src/ILGPU.Algorithms/Runtime/Cuda/CuFFTW.cs
@@ -1,6 +1,6 @@
 // ---------------------------------------------------------------------------------------
 //                                   ILGPU Algorithms
-//                           Copyright (c) 2021 ILGPU Project
+//                        Copyright (c) 2021-2023 ILGPU Project
 //                                    www.ilgpu.net
 //
 // File: CuFFTW.cs
@@ -17,7 +17,6 @@ namespace ILGPU.Runtime.Cuda
     /// <summary>
     /// Wrapper over cuFFTW to simplify integration with ILGPU.
     /// </summary>
-    [CLSCompliant(false)]
     public sealed partial class CuFFTW
     {
         /// <summary>