Random ranges #1038
Merged
Random ranges #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rs-mt
force-pushed
the
random_ranges
branch
4 times, most recently
from
eaddb70
to
6ff9aed
Compare
m4rs-mt
force-pushed
the
random_ranges
branch
3 times, most recently
from
8d86d3e
to
0bd75fb
Compare
|
Unit tests are failing in Release mode only. Need to switch to Release configuration in Visual Studio when running the unit tests, in order to reproduce the issue. Looks like it is failing become ILGPU does not support |
|
Given the fact that this PR should not change the behavior of the ILGPU tests affected at the moment, this is particularly interesting. |
|
I think this is a change in the latest .NET runtimes - our nightly builds are failing too. |
|
This would actually make sense. If this problem is related to some .NET runtime updates, we should try to address this issue in v1.5.0. |
|
@MoFtZ as this blocks all CI jobs from completing at the moment, we have to fix it asap anyway. |
m4rs-mt
force-pushed
the
random_ranges
branch
2 times, most recently
from
ef81e78
to
9240e5c
Compare
MoFtZ
approved these changes
Aug 29, 2023
m4rs-mt
added a commit
that referenced
this pull request
Aug 30, 2023
* Added new random ranges to create random numbers in certain intervals. * Added vector-specific random extensions.
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Added new random ranges to create random numbers in certain intervals. * Added vector-specific random extensions.
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Added new random ranges to create random numbers in certain intervals. * Added vector-specific random extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
IRandomRangeandIRandomRangeProviderinterfaces to define common methods to combine random number generators with[min,.. max)value ranges. It adds a text template to generateRandomRangeXYZtypes representing tuples ofminandmaxvalues with utility RNG functions. The template also generates provider implementations combining the tuples with actual RNG types likeRandomRangeXYZProvider.This PR depends on PRs
#1033, #1037, and #1057.