Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced comments and fixed typos. #1061

Merged
merged 3 commits into from
Sep 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Src/ILGPU/Backends/Backend.cs
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ public CompiledKernel Compile<TBackendHook>(
entry,
backendContext,
specialization);
if (entryPoint.IsImplictlyGrouped &&
if (entryPoint.IsImplicitlyGrouped &&
backendContext.SharedMemorySpecification.HasSharedMemory)
{
throw new NotSupportedException(
Expand Down
2 changes: 1 addition & 1 deletion Src/ILGPU/Backends/EntryPoints/EntryPoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public EntryPoint(
/// <summary>
/// Returns true if the entry point represents an implicitly grouped kernel.
/// </summary>
public bool IsImplictlyGrouped => !IsExplicitlyGrouped;
public bool IsImplicitlyGrouped => !IsExplicitlyGrouped;

/// <summary>
/// Returns the index type of the index parameter.
Expand Down
4 changes: 2 additions & 2 deletions Src/ILGPU/Backends/IL/DefaultILBackend.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// ---------------------------------------------------------------------------------------
// ILGPU
// Copyright (c) 2018-2021 ILGPU Project
// Copyright (c) 2018-2023 ILGPU Project
// www.ilgpu.net
//
// File: DefaultILBackend.cs
Expand Down Expand Up @@ -51,7 +51,7 @@ protected override void GenerateCode<TEmitter>(
if (entryPoint.MethodInfo.IsNotCapturingLambda())
emitter.Emit(OpCodes.Ldnull);

if (entryPoint.IsImplictlyGrouped)
if (entryPoint.IsImplicitlyGrouped)
{
// Load index
emitter.Emit(LocalOperation.Load, index);
Expand Down
6 changes: 3 additions & 3 deletions Src/ILGPU/Backends/PTX/PTXArgumentMapper.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// ---------------------------------------------------------------------------------------
// ILGPU
// Copyright (c) 2018-2021 ILGPU Project
// Copyright (c) 2018-2023 ILGPU Project
// www.ilgpu.net
//
// File: PTXArgumentMapper.cs
Expand Down Expand Up @@ -48,7 +48,7 @@ public MappingHandler(EntryPoint entryPoint)
public bool CanMapKernelLength(out Type indexType)
{
indexType = EntryPoint.KernelIndexType;
return EntryPoint.IsImplictlyGrouped;
return EntryPoint.IsImplicitlyGrouped;
}

public void MapKernelLength<TILEmitter, TTarget>(
Expand All @@ -57,7 +57,7 @@ public void MapKernelLength<TILEmitter, TTarget>(
where TILEmitter : struct, IILEmitter
where TTarget : struct, ITarget
{
Debug.Assert(EntryPoint.IsImplictlyGrouped);
Debug.Assert(EntryPoint.IsImplicitlyGrouped);

var argumentSource = new ArgumentSource(
kernelLengthTarget.TargetType,
Expand Down
2 changes: 1 addition & 1 deletion Src/ILGPU/Runtime/CPU/CPURuntimeContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ protected void ReleaseLock<TParent>(
where TParent : IParent
{
// If we are the main thread, release the lock by issuing an atomic
// exchange operation in order to be visible by another AquireLock
// exchange operation in order to be visible by another AcquireLock
// operation that might be executed in the future.
if (isMainThread)
Interlocked.Exchange(ref memoryLock, 0);
Expand Down
2 changes: 1 addition & 1 deletion Src/ILGPU/Runtime/Device.cs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ protected Device()
public int MaxNumThreadsPerGroup { get; protected set; }

/// <summary>
/// Returns the maximum number of shared memory per thread group in bytes.
/// Returns the maximum shared memory per thread group in bytes.
/// </summary>
public int MaxSharedMemoryPerGroup { get; protected set; }

Expand Down
2 changes: 1 addition & 1 deletion Src/ILGPU/Runtime/KernelLauncherBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public static void EmitLoadKernelConfig<TEmitter>(
int customGroupSize = 0)
where TEmitter : struct, IILEmitter
{
if (entryPoint.IsImplictlyGrouped)
if (entryPoint.IsImplicitlyGrouped)
{
Debug.Assert(customGroupSize >= 0, "Invalid custom group size");

Expand Down
Loading