Pass WriteToOutput to backends #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
approved these changes
Aug 31, 2023
m4rs-mt
force-pushed
the
write_to_output
branch
from
2a83461
to
bde9d41
Compare
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Added more code-generation functions to IBackendCodeGenerator. * Adapted Backends to updated IBackendCodeGenerator.
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Added more code-generation functions to IBackendCodeGenerator. * Adapted Backends to updated IBackendCodeGenerator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the current behavior which blocks
WriteToOutputnodes from being sent to the code generators of each backend directly. This was not required in the past. However, upcoming backends may need to generate custom code for these instructions within the code generators directly.