Fixed IfConversion #1081
Merged
Fixed IfConversion #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rs-mt
force-pushed
the
if_conversion
branch
from
817eecf
to
c7145da
Compare
m4rs-mt
force-pushed
the
if_conversion
branch
3 times, most recently
from
c0f356e
to
d2cd747
Compare
m4rs-mt
force-pushed
the
if_conversion
branch
from
d2cd747
to
16b238d
Compare
MoFtZ
approved these changes
Sep 6, 2023
m4rs-mt
force-pushed
the
if_conversion
branch
from
16b238d
to
537e97e
Compare
m4rs-mt
force-pushed
the
if_conversion
branch
from
537e97e
to
efbfb02
Compare
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Sep 8, 2023
* Extended PhiBindings analysis to check for individual branch targets. * Fixed IfConversion transformation phasing possibilities of endless loop branches. * Fixed PTXCodeGenerator to emit individual target bindings. * Added new test case for improved IfConversion transformation.
Merged
m4rs-mt
added a commit
that referenced
this pull request
Sep 12, 2023
* Fixed IfConversion. - Backported #1081. Co-authored-by: Marcel Koester <[email protected]>
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Extended PhiBindings analysis to check for individual branch targets. * Fixed IfConversion transformation phasing possibilities of endless loop branches. * Fixed PTXCodeGenerator to emit individual target bindings. * Added new test case for improved IfConversion transformation.
MoFtZ
pushed a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 24, 2024
* Extended PhiBindings analysis to check for individual branch targets. * Fixed IfConversion transformation phasing possibilities of endless loop branches. * Fixed PTXCodeGenerator to emit individual target bindings. * Added new test case for improved IfConversion transformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in the
IfConversiontransformation that could happen in the presence of endless loops and loops that cannot be proven to terminate easily.