Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE] Refactoring Docs/ folder #849

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Conversation

naskio
Copy link
Contributor

@naskio naskio commented Sep 14, 2022

  • Refactoring Docs/ folder in order to match the naming convention.

@m4rs-mt
Copy link
Owner

m4rs-mt commented Sep 21, 2022

One of the recent contributions changed the existing syntax highlighting functionality. Therefore, this PR has some conflicts. @naskio Can you resolve the current conflicts and push and updated version?

Copy link
Contributor

@NullandKale NullandKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything other than the one change to white space for the c# like code formatting is good.

Not super important other than changing the one spelling mistake and renaming a few files.

I will approve this merge if the comment can be addressed

Docs/04_Upgrade-Guides/04_v0.6.X-to-v0.7.X.md Outdated Show resolved Hide resolved
Copy link
Owner

@m4rs-mt m4rs-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me know. However, seems to be the case that there are still some conflicts to address.

@naskio
Copy link
Contributor Author

naskio commented Oct 31, 2022

Looks good to me know. However, seems to be the case that there are still some conflicts to address.

Can you please re-check now ?

@m4rs-mt m4rs-mt merged commit e4cd57f into m4rs-mt:master Oct 31, 2022
@naskio naskio deleted the refactoring-docs branch October 31, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants