Added support for net70. #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cannot return local variable `condition` by reference.
m4rs-mt
reviewed
Dec 2, 2022
m4rs-mt
reviewed
Dec 2, 2022
m4rs-mt
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for compiling ILGPU using the .NET 7.0 SDK.
The CI pipeline has been modified to use the newer SDK. The
dotnettool appears to have swapped the order of some arguments, so this has been adjusted.Updated the C# language version to 9, to fix an issue with
IntPtr- it is now treated as anint, which only became available in C# 9.Fixed various compiler warnings. In particular, our custom
DisposeAcceleratorObjectfunction is not recognised by the Dispose pattern.Fixed issues with the
inparameter modifier. The mean appears to have changed. Previously, it behaved more like "here is a read-only struct". We would copy the struct when it was used. Now, the "this is passed by reference" is being enforced. So we have modified ILGPU to remove theinparameter modified, and to copy the struct as the argument.Fixed an issue with the
refparameter modifier. This appears to be more strictly enforced. We used to return a reference to a local variable, but now that is no longer permitted.Finally, fixed an issue with
Unsafe.As. This has become a .NET intrinsic, and no longer provides MSIL code. We have had to replicate it's behavior within ILGPU.