Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT messages continuing long after switch turned off #113

Closed
gmalbert opened this issue Feb 24, 2020 · 3 comments
Closed

MQTT messages continuing long after switch turned off #113

gmalbert opened this issue Feb 24, 2020 · 3 comments

Comments

@gmalbert
Copy link

Describe the bug
A clear and concise description of what the bug is.
After turning off the switch in HA, the mqtt messages continue and don't stop. There's no way to stop the mqtt messages other than stopping the service.
To reproduce
Steps required to reproduce the issue.

Relevant configuration
Paste the relevant parts of your configuration below.

Expected behavior
A clear and concise description of what you expected to happen.
In 2.0 beta up to and including 5, the HA switch stopped RA from continuing to check whether the devices are still around. This was the expected behavior and (I believe) the reason for the HA switch in the first place. However, as of beta 6, even turning off the switch does not stop the messages from continuing until the service is actually stopped.

There is a good argument that showing not_home should not mean that RA should stop searching. However, there are valid use cases (like being gone for the day) in which it would be helpful to turn off the continual checks until a certain time or trigger.
Environment

  • room-assistant version: [e.g. 2.0.0]
  • installation type: [e.g. NodeJS, Docker, Hass.io]
  • hardware: [e.g. Raspberry Pi Zero W, NUC]
  • OS: [e.g. Linux, Windows, macOS]
    Node JS on Raspberry pi zero w. The issue occurs on betas 6 and above, including the full 2.0.0 release on both NUC and the raspberry pi zero w.
    Additional context
    Add any other context about the problem here.

I had referenced this issue just before RA went to the 2.0.0 release, so I'm reposting here since the previous issue had been closed upon release. https://github.com/mKeRix/room-assistant/issues/102#issuecomment-589779775

@gmalbert gmalbert added the bug label Feb 24, 2020
@mKeRix
Copy link
Owner

mKeRix commented Feb 24, 2020

Thanks for bringing this to my attention again! It got lost under all the other topics. I will restore the old behavior in the sense that the last_updated_at will not be set anymore after the sensor has gone not_home asap.

@mKeRix mKeRix closed this as completed in 6e9f31a Feb 27, 2020
github-actions bot pushed a commit that referenced this issue Feb 27, 2020
## [2.0.1](v2.0.0...v2.0.1) (2020-02-27)

### Bug Fixes

* stop attribute updates when not_home ([6e9f31a](6e9f31a)), closes [#113](#113)
* **config:** log configuration sources ([0d47a54](0d47a54))
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gmalbert
Copy link
Author

@mKeRix working perfectly. Thank you for the quick update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants