Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery prefix #546

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Discovery prefix #546

merged 2 commits into from
Feb 22, 2021

Conversation

Apocrathia
Copy link
Contributor

Describe the change
Added the configuration option for the MQTT discoveryPrefix for the homeAssistant integration.

Checklist
If you changed code:

  • Tests run locally and pass (npm test)
  • Code has correct format (npm run format)

If you added a new integration:

  • Documentation page added in docs/integrations/ (Documentation updated)
  • Page linked in docs/.vuepress/config.js and docs/integrations/README.md (N/A)

Additional information
First time working with TypeScript, so let me know if I need to fix anything.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #546 (168b768) into master (7c69b1e) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   91.37%   91.70%   +0.32%     
==========================================
  Files          89       89              
  Lines        2180     2266      +86     
  Branches      328      359      +31     
==========================================
+ Hits         1992     2078      +86     
  Misses        184      184              
  Partials        4        4              
Flag Coverage Δ
unittests 91.70% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/integrations/home-assistant/entity-config.ts 100.00% <100.00%> (ø)
...tegrations/home-assistant/home-assistant.config.ts 100.00% <100.00%> (ø)
...egrations/home-assistant/home-assistant.service.ts 97.93% <100.00%> (+0.01%) ⬆️
...ions/bluetooth-classic/bluetooth-classic.config.ts 100.00% <0.00%> (ø)
...uetooth-low-energy/bluetooth-low-energy.service.ts 100.00% <0.00%> (ø)
...ons/bluetooth-classic/bluetooth-classic.service.ts 98.31% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c69b1e...168b768. Read the comment docs.

Copy link
Owner

@mKeRix mKeRix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for the long time to review, it's a busy time for me currently.

@mKeRix mKeRix merged commit 1056bb5 into mKeRix:master Feb 22, 2021
@Apocrathia
Copy link
Contributor Author

No worries. Glad everything looks good and I was able to contribute to the project. Thanks for your work!

@Apocrathia Apocrathia deleted the discoveryPrefix branch February 23, 2021 00:28
github-actions bot pushed a commit that referenced this pull request Feb 28, 2021
# [2.14.0](v2.13.1...v2.14.0) (2021-02-28)

### Bug Fixes

* **bluetooth:** respect connecting state during retry ([8f36d87](8f36d87))
* **entities:** prevent dates from being proxied ([d861486](d861486))

### Features

* add generic MQTT integration ([848a25b](848a25b)), closes [#434](#434)
* **bluetooth-classic:** allow id overrides ([f5fc88d](f5fc88d))
* **bluetooth-low-energy:** allow id overrides ([e41034e](e41034e)), closes [#433](#433)
* **entities:** bunch entity updates together ([52f0197](52f0197))
* **home-assistant:** add discoveryPrefix option ([#546](#546)) ([1056bb5](1056bb5))
@github-actions
Copy link

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants