Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --proxy-type functionality for Chrome/Chromium renderers. #51

Closed
wants to merge 1 commit into from
Closed

Add --proxy-type functionality for Chrome/Chromium renderers. #51

wants to merge 1 commit into from

Conversation

zonicdoe
Copy link

Proposed change

Add some code that allows you to specify the type of proxy to use with the Chrome/Chromium renderer.

Fixes

It prevents the error shown below when using a socks proxy with the Chrome/Chromium renderer:

Chromium

@maaaaz
Copy link
Owner

maaaaz commented Apr 11, 2020

Hello @zonicdoe,

Thanks, you're right.
It might be a lack of documentation but you can already specify the proxy type in the --proxy option for chrome/chromium renderers.

A --proxy socks://foobar or --proxy http://foobar should already work without the need of --proxy-type option which was used in the early days as a direct mapping of phantomjs options.

@zonicdoe
Copy link
Author

Now that you mention it, it seems pretty obvious. Thanks ;)

@zonicdoe zonicdoe closed this Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants