Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explicit default port #143

Merged
merged 1 commit into from
Dec 5, 2017
Merged

remove explicit default port #143

merged 1 commit into from
Dec 5, 2017

Conversation

Juul
Copy link
Contributor

@Juul Juul commented Dec 5, 2017

nodemw was telling the request module to explicitly specify port 80/443 as part of the URL even though it is not necessary and in fact breaks functionality for some mediawiki installations (e.g. openwetware).

The URLs would look like https://myserver.org:443/wiki before this fix and I was getting the following from openwetware:

<!DOCTYPE html>
<html>
  <head>
    <title>503 Backend fetch failed</title>
  </head>
  <body>
    <h1>Error 503 Backend fetch failed</h1>
    <p>Backend fetch failed</p>
    <h3>Guru Meditation:</h3>
    <p>XID: 11808784</p>
    <hr>
    <p>Varnish cache server</p>
  </body>
</html>

@Juul Juul mentioned this pull request Dec 5, 2017
Open
@macbre macbre merged commit 2470f9d into macbre:devel Dec 5, 2017
@macbre macbre added the bug label Dec 5, 2017
@macbre macbre added this to the v0.13 milestone Dec 5, 2017
@macbre
Copy link
Owner

macbre commented Dec 5, 2017

Thanks, @Juul !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@Juul @macbre