-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PhantomJS 2.1.1 #488
Comments
Waiting for fixes for Linux binaries - ariya/phantomjs#12970 |
any estimate on this? |
Waiting for phantomjs issue being resolved |
what do these new binaries afford us? |
Well, for starters 1.9.1 seems to currently fail to install on windows due to ws version failing currently. Which is due to socket.io having issues. 2.x doesn't have the issue |
|
Forked |
So we're getting some progress? |
I believe PhantomJS 2 has better support for SNI -- the lack of support in PhantomJS 1 makes phantomas fail on HTTPS sites which require SNI. |
@Martinspire, no progress. Still waiting for 32-bit and Debian-compatible binaries. I think we'll end up forking |
Good news, everyone :) I've managed to compile PhantomJS 2 binary using Docker (running Ubuntu 14.04 image) with statically-linked libraries (#540 / macbre/phantomjs2-npm#1). It runs smoothly on Debian 8.1 amd64. |
That's fantastic! I added myself as a subscriber to #531, and will happily test phantomas out on a batch of |
👍 |
@konklone, @gmetais - #531 is now merged into devel branch. You can use PhantomJS 2.0.0 by settings an environment variable:
or passing
|
Thanks for your great work! It fails on OSX, here is the debug log:
It's working correctly in an Ubuntu VM, I'm going to make some comparison tests between 1.9 and 2.0 :) |
This is working great on Linux. Fixes these bugs:
|
Great! As for the OSX problems - can you run phantomas with |
There's not more output with the --debug argument:
|
@gmetais, it seems that PhantomJS segfaults on OSX. Can you reproduce this issue on different URLs? |
On any URL. In fact, it fails so quickly (less than 250ms, I guess) that it probably doesn't have the time to start calling the URL. |
Hey @macbre! For your information, the public http://yellowlab.tools instance has been using PhantomJS 2 for one week, testing hundreds of websites, and no-one has complained yet! (It's using your devel branch.) Just wanted to share this good news! |
Glad to hear that :) |
Since #531 PhantomJS 2.0 is one of supported engines. Because of problems with statically linked binaries for Linux, I'm not going to make PhantomJS 2 a default engine, yet. |
ariya/phantomjs#12970 - PhantomJS 2.1 released! |
It did take a while, but we can now use official binaries for PhantomJS 2.x, |
😌 |
Was there a resolution for this I'm getting the following issue (phantomjs 2.1.1, and phantomas v1.20.1):
|
ariya/phantomjs#12902
The text was updated successfully, but these errors were encountered: