Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when importing not existing engine #542

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jul 11, 2015

See #488

  phantomas:engines Engine "webkit2": failed to import - Error: Cannot find module 'phantomjs2'

phantomjs2 npm module fails to install on Linux ia32:

> [email protected] install /home/macbre/github/phantomas/node_modules/phantomjs2
> node install.js

There is no prebuilt binary for your platform: linux ia32 3.2.0-4-686-pae
You should install phantomjs from source, put the binary on your PATH, and try again

npm ERR! [email protected] install: `node install.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is most likely a problem with the phantomjs2 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls phantomjs2
npm ERR! There is likely additional logging output above.

@macbre macbre added the bug label Jul 11, 2015
@macbre macbre added this to the v1.12 milestone Jul 11, 2015
macbre pushed a commit that referenced this pull request Jul 11, 2015
Do not fail when importing not existing engine
@macbre macbre merged commit 70b1c91 into devel Jul 11, 2015
@macbre macbre deleted the safe-engines-import branch July 11, 2015 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant