Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml created for Travis-CI Implementation #8

Closed
wants to merge 12 commits into from
Closed

.travis.yml created for Travis-CI Implementation #8

wants to merge 12 commits into from

Conversation

MichaelTamaki
Copy link
Contributor

Installs scikit, numpy, and librosa without errors.
Test suite returns errors, next step is to fix the tests.

@stefanv
Copy link
Contributor

stefanv commented Oct 18, 2016

Closes #3

- "3.5"

before_install:
- pip install --no-index --trusted-host travis-wheels.scikit-image.org --find-links=http://travis-wheels.scikit-image.org numpy scipy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now wheels available on pypi, so you should be able to do:

pip install numpy scipy

# command to install dependencies
# install: "pip install -r requirements.txt"
install:
# - pip install numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two commented lines

install:
# - pip install numpy
# - pip install scikit
- pip install librosa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add librosa to requirements.txt, and change this line to pip install -r requirements.txt. Then, remove the comment above referring to this instruction.

- pip install librosa

# command to run tests
script: nosetests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move to pytest?

@MichaelTamaki
Copy link
Contributor Author

MichaelTamaki commented Oct 18, 2016

@stefanv Changed the file based off of comments. The current test suite uses nosetests, so it will crash if we run pytest.
Also, the test cases state that it uses librosa v. 1.6.1. Should I implement this in the travis file?

@stefanv
Copy link
Contributor

stefanv commented Oct 18, 2016

You can specify versions in the requirements.txt:

librosa==1.6.1

Then please open another issue for migrating to the latest librosa (or test, perhaps it already works!)

It's ok to stick with nose for now, we can fix that in another PR.

@stefanv
Copy link
Contributor

stefanv commented Oct 20, 2016

Does that work, @MichaelTamaki ?

@MichaelTamaki
Copy link
Contributor Author

Found out that librosa 1.6.1 does not exist. The latest version available is 0.4.3. Will need to test which versions work with the code.

@stefanv stefanv closed this Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants