Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer config #265

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 3, 2023

Addresses #251, replaces #252

Modify the following aspects of the previous container:

  • Only had the root user in the container, causing permission issues when run locally.
  • The version of Quarto CLI was hard coded and the new version could not be installed without updating the file.
  • Arm64 support lacks.
  • Dockerfile had to be included in the repository.

@machow
Copy link
Owner

machow commented Sep 7, 2023

Thanks for this PR! I opened in codespaces and it seems to work great!

I'm not too familiar with devcontainers. Any chance you might be able to weigh in on these pieces from the siuba workshop config?

Thanks again! I'm also happy to take from here / merge if useful!

@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 7, 2023

"waitfor": "onCreateCommand": does this seem worth adding? It looks like it might not work in codespaces, but I guess will work when people create the devcontainer locally?

I think it is the same as the default value.
https://containers.dev/implementors/spec/#post-container-creation

installing the jupyter extension: I was able to get the "Run Code" button to appear in qmds after installing this. Do you mind adding? :)

I think it is worth adding. Feel free to add this PR.

@machow
Copy link
Owner

machow commented Sep 7, 2023

Added--Thanks again for your help!

@machow machow merged commit 8e03839 into machow:main Sep 7, 2023
4 of 5 checks passed
@eitsupi eitsupi deleted the update-devcontainer branch September 7, 2023 22:16
"vscode": {
"extensions": [
"ms-toolsai.jupyter",
"ms-python.python"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in the base image, so not needed here.

"label": "Jupyter"
}
},
"vscode": {
Copy link
Contributor Author

@eitsupi eitsupi Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top level vscode field is the old syntax (I think this is not included in the Devcontainer spec).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants