Add two new queue macros with tests, plus a warning fix. #94
Conversation
Fixes declaration visibility warning for "struct stat64", on 10.4 where this whole test is invalid, anyway. Also removes unused FEEDBACK macro. TESTED: Warning is now gone on 10.4.
Several other queue macros are also missing, which is not covered by this commit. Closes: https://trac.macports.org/ticket/69890 TESTED: Builds and passes tests on all platforms, including the new tests for the new macros.
This adds a long-missing test for STAILQ_FOREACH, as well as a test for the newly added SLIST_REMOVE_AFTER (which also tests SLIST_HEAD_INITIALIZER). Re: https://trac.macports.org/ticket/69890 TESTED: Detects missing STAILQ_FOREACH in 10.4 SDK (without old fix). Detects missing SLIST_HEAD_INITIALIZER in 10.4 SDK (without new fix). Detects missing SLIST_REMOVE_AFTER in 10.4-10.6 SDKs (without new fix). With fixes, passes with all applicable SDKs on all platforms.
|
@mascguy |
Yes indeed, and looks good to me. |
|
I'll wait until an appropriately updated #93 is also merged before making another -devel update. This completes what I'd planned for this release cycle, so the next -devel will probably be an RC. With the extent of the changes, it might be a good idea to call for wider testing at that point. |
Sounds good. And agreed, wider testing would be a good thing. |
See the individual commit messages.