Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtommath: better PPC support for MoarVM #14417

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

evanmiller
Copy link
Contributor

Description

Modify the patch from #14336 to support PowerPC. Necessitates a rev-bump because libtommath itself builds on PPC but won't allow MoarVM to build.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.4.11
Xcode x.y

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@reneeotten
Copy link
Contributor

reneeotten commented Mar 31, 2022

one probably should only increase the revision then on ppc in this case.

I don't think we have buildbots for that anyway, so none of the binaries will be affected and should be rebuild - right?

@mojca
Copy link
Member

mojca commented Mar 31, 2022

one probably should only increase the revision then on ppc in this case.

We never do that. While technically correct, it could lead to quite some confusion with no good reason.

I don't think we have buildbots for that anyway, so none of the binaries will be affected and should be rebuild - right?

But that's a good point. No, we don't have a functional buildbot at the moment.
In theory it would still help affected users on PPC, but given that:

  • this would only affect users who want to use MoarVM
  • MoarVM never worked on PPC to start with
  • MoarVM used to be in conflict with this port
    I suspect that in reality this only affects 1-2 developers (and one of them submitted the PR).

Then again, this library is relatively small, so no reason to care that much, no reason for second thoughts.

@reneeotten
Copy link
Contributor

reneeotten commented Mar 31, 2022

fine with me @mocja and since the port has no maintainer I'll just merge his then.

I do think there is some precedence in selectively increasing the revision for certain systems, but certainly agree that's a bit more messy since someone will need to remember to remove that if-statement containing incr revision at the next update.

@reneeotten reneeotten merged commit 2ab43b6 into macports:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants