Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blender: update to 2.93.11 #16893

Merged
merged 10 commits into from
Apr 28, 2023
Merged

blender: update to 2.93.11 #16893

merged 10 commits into from
Apr 28, 2023

Conversation

catap
Copy link
Contributor

@catap catap commented Dec 5, 2022

Description

Update to blender 3.x is required to update much more ports. Frankly, all this ports contains tons of patches and reinplace that makes such update a nightmare.

But I've achieved TLS version of blender which I can build via MacPorts on my laptop.

Much better than port which can't be build :)

Unfortently I can't switch it to OneTBB because some dependencies haven't supported OneTBB yet: PixarAnimationStudios/OpenUSD#1471 or PixarAnimationStudios/OpenSubdiv#1234 for example

Type(s)
  • bugfix
  • enhancement
Tested on

macOS 12.6 21G115 x86_64
Xcode 14.1 14B47b

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@jasonliu-- for port blender, embree, materialx, oidn, opensubdiv, openvdb, osl, partio, usd.
@MarcusCalhoun-Lopez for port opencolorio, openimageio, openvdb.

@jasonliu--
Copy link
Contributor

Do you know whether your PR is able to be built on MacOS 10.11? I use MacPorts on my 10.11 laptop, and I have spent quite a lot of effort to keep the MacPorts builds for Blender running under 10.11.

@catap
Copy link
Contributor Author

catap commented Dec 13, 2022

@jasonliu-- I haven't tried it on 10.11 to be honest

@jasonliu--
Copy link
Contributor

Is this ticket either a blocker for openvdb, or is your PR supposed to resolve this issue?

https://trac.macports.org/ticket/66463

@catap
Copy link
Contributor Author

catap commented Dec 13, 2022

@jasonliu-- yes, it should fix this ticket

@catap
Copy link
Contributor Author

catap commented Dec 14, 2022

Just rebased to the last master.

@jasonliu--
Copy link
Contributor

I would like to verify that this PR still allows the Blender port to work on my 10.11 machine. Since there are so many changes, it will take me some time to re-compile all of the dependencies. I will report back here when I have obtained results.

@catap
Copy link
Contributor Author

catap commented Jan 1, 2023

@reneeotten if I rebase this one are you willing to merge it? :)

@reneeotten
Copy link
Contributor

I will not unless @jasonliu-- agrees/approves

@jasonliu--
Copy link
Contributor

jasonliu-- commented Jan 2, 2023

I'm having a difficult time coming to grips with all of the changes that were made in this PR. So many dependent ports have been updated at once in this one PR... in addition, some dependencies have also received an update in #16915.

I appreciate all of the effort that I'm sure you have put into these couple of PRs, but as the person who generally maintains most of these ports, it's quite difficult for me to do verification if you lump all of the updates into one PR.

@catap
Copy link
Contributor Author

catap commented Jan 2, 2023

@jasonliu-- #16915 is blocked by this PR. As soon as this one is merged, it decreases the size of #16915 :) because it contains this one and a lot of another PRs.

:)

@catap
Copy link
Contributor Author

catap commented Jan 2, 2023

BTW I've just rebased it to the last master

@reneeotten
Copy link
Contributor

since January 1st, Python 3.11 is the default so if possible let’s set that as the default for ports in this PR as well?

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

Building it finally on 10.11

@catap catap marked this pull request as ready for review April 25, 2023 17:43
@catap catap marked this pull request as draft April 25, 2023 17:47
@catap catap marked this pull request as ready for review April 25, 2023 18:33
@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@mascguy it successfully builds on macOS 10.11, anyway, it won't start in virtual machine because it required OpenGL 3.1 or something like that.

But after diging for couple of hours (like 6) why I've discovered a bypass: BLENDER_SOFTWAREGL. This is an environment variable. So, by running a command env BLENDER_SOFTWAREGL=1 open /Applications/MacPorts/Blender.app I've started it and captures screenshots.

Screenshot 2023-04-25 at 22 16 43

Screenshot 2023-04-25 at 22 16 47

@mascguy
Copy link
Member

mascguy commented Apr 25, 2023

@mascguy it successfully builds on macOS 10.11, anyway, it won't start in virtual machine because it required OpenGL 3.1 or something like that.

But after diging for couple of hours (like 6) why I've discovered a bypass: BLENDER_SOFTWAREGL. This is an environment variable. So, by running a command env BLENDER_SOFTWAREGL=1 open /Applications/MacPorts/Blender.app I've started it and captures screenshots.

That is awesome Kirill, great work!

So are we ready to merge, once CI completes?

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@mascguy I guess this was the last remark :)

@mascguy
Copy link
Member

mascguy commented Apr 25, 2023

Given that Kirill has confirmed that this all works on 10.11, are there any objections to merging (once CI conpletes)?

@reneeotten and @jasonliu-- ?

@catap
Copy link
Contributor Author

catap commented Apr 25, 2023

@mascguy from my point of view all remarks addresed and this is ready to be merged.

@mascguy
Copy link
Member

mascguy commented Apr 26, 2023

@mascguy from my point of view all remarks addresed and this is ready to be merged.

Sounds good, let's give Renee and Jason a few days to respond.

@catap
Copy link
Contributor Author

catap commented Apr 27, 2023

@mascguy that should we do with this one?

@mascguy
Copy link
Member

mascguy commented Apr 27, 2023

I'm definitely fine with this, and would love to see it merged.

But it's only been two days, so let's give folks another few days to respond.

@catap
Copy link
Contributor Author

catap commented Apr 27, 2023

@mascguy thanks, it's clear. I'm pushing at two PRs because they are blocker for my huge TBB/OneTBB mess fix up, which is blocking a few another updates :)

@jasonliu--
Copy link
Contributor

@mascguy, do you need to run the command with the added environment variable each and every time you start Blender? Or is this something the could be incorporated during the build process?

@mascguy
Copy link
Member

mascguy commented Apr 28, 2023

@mascguy, do you need to run the command with the added environment variable each and every time you start Blender? Or is this something the could be incorporated during the build process?

To make it seamless, we'd probably want to use a launch script [within the app bundle] to set it when necessary.

Kirill, is that something you'd mind doing?

@jasonliu--
Copy link
Contributor

If it should be in a launch script, then maybe we could make it a separate PR. I would be willing to submit that PR, since I have to create launch scripts for some of the open source games that I have made Portfiles for, so I could probably grab some of my existing code from those to repurpose for this case.

@mascguy
Copy link
Member

mascguy commented Apr 28, 2023

If it should be in a launch script, then maybe we could make it a separate PR. I would be willing to submit that PR, since I have to create launch scripts for some of the open source games that I have made Portfiles for, so I could probably grab some of my existing code from those to repurpose for this case.

Sounds great! So can can we go ahead and merge this PR as-is then?

@catap
Copy link
Contributor Author

catap commented Apr 28, 2023

@jasonliu--, @mascguy this environment variable only required because I've tested it inside virtual machine with quite poor OpenGL implementation.

For real use case it doesn't needed.

Have I missed something?

Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is now covered - including 10.11 - so we're good-to-go.

@mascguy mascguy merged commit f7e2c9f into macports:master Apr 28, 2023
@catap catap deleted the blender branch April 28, 2023 13:38
@catap
Copy link
Contributor Author

catap commented Apr 28, 2023

Yahooo! Thanks Christopher!

@jasonliu--
Copy link
Contributor

jasonliu-- commented Apr 28, 2023

@jasonliu--, @mascguy this environment variable only required because I've tested it inside virtual machine with quite poor OpenGL implementation.

For real use case it doesn't needed.

Have I missed something?

That probably makes a certain amount of sense, since many virtual machine softwares aren't perfectly able to pass through hardware graphics rendering between the guest and host OSes. My googling skills are failing me right now, but I seem to recall that using BLENDER_SOFTWAREGL=1 was also quite inefficient, and puts a lot of additional load on the CPU.

But the environment variable is certainly a great find by @mascguy, since it's very likely that I'll probably need to use it personally going forward, as I spin up a macOS 10.11 virtual machine to do my MacPorts dev/testing, in preparation for the day that my physical 10.11 machine might die.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants