Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eligibility-util: submission #25831

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

eligibility-util: submission #25831

wants to merge 2 commits into from

Conversation

i0ntempest
Copy link
Member

@i0ntempest i0ntempest commented Sep 19, 2024 •
edited
Loading

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: submission by: member Created by a member with commit rights labels Sep 19, 2024
@i0ntempest i0ntempest force-pushed the eligibility branch 4 times, most recently from ad7b6ec to 7c586b1 Compare September 19, 2024 08:41
@i0ntempest i0ntempest mentioned this pull request Sep 19, 2024
Closed
12 tasks
@markemer
Copy link
Member

Could we add like a csrutil status check with a failure if you don't use the +sip variant?

@i0ntempest
Copy link
Member Author

Could we add like a csrutil status check with a failure if you don't use the +sip variant?

Might be better to add some conditional notes. After all SIP status does not affect buiding the port.

@i0ntempest i0ntempest force-pushed the eligibility branch 2 times, most recently from ca825f5 to f784e8e Compare September 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten left review comments

@markemer markemer markemer left review comments

Assignees
No one assigned
Labels
by: member Created by a member with commit rights type: submission
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@i0ntempest @markemer @reneeotten @macportsbot