- Created a new subport for obspy (py312-obspy). Adding a listing fil…

[jolivetr]

…e obspy312.

Description

Update obspy portfile to python 3.12

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 12.7.6 21H1320 arm64
Xcode 14.2 14C18

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@petrrr for port py-obspy.

[jolivetr]

Building fails when attempting to build with py38 and py39. I suggest we remove support for these old versions of python.

Who makes that decision? Obspy developers, Portfile owner or someone else?

[reneeotten]

there is one test dependency missing for the PY312 subport which the linter warns you about:

port lint py312-obspy:
Error: Unknown dependency: py312-pytest-json-report

that should be resolved in this PR as well.

Additionally, your commit message does not follow the guidelines - it should be portname: short description. So in this case something like: py-obspy: add py312 subport.

[reneeotten]

this is the default now and the line can thus be removed

[reneeotten]

Building fails when attempting to build with py38 and py39. I suggest we remove support for these old versions of python.

Who makes that decision? Obspy developers, Portfile owner or someone else?

Upstream claims to support Python 3.8 and above so technically these subports should build.... I will look at the CI logs in a minute. Having said that, this port has no dependents and it's reasonable to assume people can use a modern Python version. Typically, the policy is to remove subports for EOL versions (which PY38 almost is) and at this time removing PY39 would be fine as well; a port maintainer can decide which subports to add.

[reneeotten]

the PY38/PY39 subports fail because one of their dependencies doesn't install:

  Building dependency (1 of 1) 'py38-cartopy' with variants '' ... [FAIL] (checksum)

that is something that should be fixed; ideally in this PR as well.

Having said that, if you'd like to remove the almost EOL Python 3.8 subport that's fine. It would be preferable though to fix the checksums issue regardless.