Merge pull request #251 from madgik/bug_rmi_timeout

Bug rmi timeout
madgik · May 19, 2020 · 56404df · 56404df
2 parents b1c7db1 + ba15189
commit 56404df
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 10 deletions.
diff --git a/Exareme-Docker/files/root/exareme/exareme-admin.sh b/Exareme-Docker/files/root/exareme/exareme-admin.sh
@@ -95,6 +95,12 @@ function start_exareme(){               #Starts exareme daemon
        -Djava.rmi.server.codebase=file:$EXAREME_HOME/lib/exareme/   \
        -Djava.security.policy=$EXAREME_HOME/etc/exareme/art.policy  \
        -Djava.rmi.server.hostname=$EXAREME_MASTER                   \
+       -Dsun.rmi.activation.execTimeout=$NODE_COMMUNICATION_TIMEOUT          \
+       -Dsun.rmi.activation.groupTimeout=$NODE_COMMUNICATION_TIMEOUT         \
+       -Dsun.rmi.transport.connectionTimeout=$NODE_COMMUNICATION_TIMEOUT     \
+       -Dsun.rmi.transport.proxy.connectTimeout=$NODE_COMMUNICATION_TIMEOUT  \
+       -Dsun.rmi.transport.tcp.handshakeTimeout=$NODE_COMMUNICATION_TIMEOUT  \
+       -Dsun.rmi.transport.tcp.responseTimeout=$NODE_COMMUNICATION_TIMEOUT   \
        -Dcom.sun.management.jmxremote.port=$EXAREME_ADMIN_JMX_PORT  \
        -Dcom.sun.management.jmxremote.authenticate=false            \
        -Dcom.sun.management.jmxremote.ssl=false                     \

diff --git a/Exareme-Docker/files/root/exareme/start-worker.sh b/Exareme-Docker/files/root/exareme/start-worker.sh
@@ -11,6 +11,10 @@ EXAREME_ADMIN_OPTS="${EXAREME_JAVA_OPTS}  \
     -Djava.rmi.server.codebase=file:$EXAREME_HOME/lib/exareme/ \
     -Djava.security.policy=$EXAREME_HOME/etc/exareme/art.policy\
     -Djava.rmi.server.hostname=$MY_IP                          \
+    -Dsun.rmi.activation.execTimeout=$NODE_COMMUNICATION_TIMEOUT    \
+    -Dsun.rmi.activation.groupTimeout=$NODE_COMMUNICATION_TIMEOUT   \
+    -Dsun.rmi.dgc.ackTimeout=$NODE_COMMUNICATION_TIMEOUT            \
+    -Dsun.rmi.transport.tcp.readTimeout=$NODE_COMMUNICATION_TIMEOUT \
     -Dcom.sun.management.jmxremote.port=$EXAREME_ADMIN_JMX_PORT\
     -Dcom.sun.management.jmxremote.authenticate=false          \
     -Dcom.sun.management.jmxremote.ssl=false                   \

diff --git a/.../src/main/java/madgik/exareme/master/gateway/async/handler/entity/NQueryResultEntity.java b/.../src/main/java/madgik/exareme/master/gateway/async/handler/entity/NQueryResultEntity.java
@@ -73,7 +73,7 @@ public void produceContent(ContentEncoder encoder, IOControl ioctrl)
             log.trace("|" + queryStatus.getError() + "|");
             if (queryStatus.getError().contains("ExaremeError:")) {
                 String data = queryStatus.getError().substring(queryStatus.getError().lastIndexOf("ExaremeError:") + "ExaremeError:".length()).replaceAll("\\s", " ");
-                //type could be error, user_error, warning regarding the error occured along the process
+                //type could be error, user_error, warning regarding the error occurred along the process
                 String type = user_error;
                 String result = defaultOutputFormat(data, type);
                 logErrorMessage(result);
@@ -82,7 +82,7 @@ public void produceContent(ContentEncoder encoder, IOControl ioctrl)
                 close();
             } else if (queryStatus.getError().contains("PrivacyError")) {
                 String data = "The Experiment could not run with the input provided because there are insufficient data.";
-                //type could be error, user_error, warning regarding the error occured along the process
+                //type could be error, user_error, warning regarding the error occurred along the process
                 String type = warning;
                 String result = defaultOutputFormat(data, type);
                 logErrorMessage(result);
@@ -91,25 +91,25 @@ public void produceContent(ContentEncoder encoder, IOControl ioctrl)
                 close();
             } else if (queryStatus.getError().contains("java.rmi.RemoteException")) {
                 String data = "One or more containers are not responding. Please inform the system administrator.";
-                //type could be error, user_error, warning regarding the error occured along the process
+                //type could be error, user_error, warning regarding the error occurred along the process
                 String type = error;
                 String result = defaultOutputFormat(data, type);
                 logErrorMessage(result);
                 encoder.write(ByteBuffer.wrap(result.getBytes()));
                 encoder.complete();
                 close();
             } else if (queryStatus.getError().contains("java.lang.IndexOutOfBoundsException:")) {
-                String data = "Something went wrong. Clean-ups were made, you may re-run your experiment. Please inform the system administrator though for fixing any remaining issue.";
-                //type could be error, user_error, warning regarding the error occured along the process
+                String data = "Something went wrong. Please inform the system administrator.";
+                //type could be error, user_error, warning regarding the error occurred along the process
                 String type = error;
                 String result = defaultOutputFormat(data, type);
                 logErrorMessage(result);
                 encoder.write(ByteBuffer.wrap(result.getBytes()));
                 encoder.complete();
                 close();
             } else {
-                String data = "Something went wrong. Please inform your system administrator to consult the logs.";
-                //type could be error, user_error, warning regarding the error occured along the process
+                String data = "Something went wrong. Please inform the system administrator.";
+                //type could be error, user_error, warning regarding the error occurred along the process
                 String type = error;
                 String result = defaultOutputFormat(data, type);
                 logErrorMessage(result);

diff --git a/Federated-Deployment/Compose-Files/docker-compose-master.yml b/Federated-Deployment/Compose-Files/docker-compose-master.yml
@@ -49,8 +49,9 @@ services:
       - CONSULURL=${EXAREME_KEYSTORE}
       - FEDERATION_ROLE=${FEDERATION_ROLE}
       - NODE_NAME=${FEDERATION_NODE}
-      - ENVIRONMENT_TYPE=PROD     #TEST / DEV / PROD
       - TEMP_FILES_CLEANUP_TIME=30
+      - NODE_COMMUNICATION_TIMEOUT=30000        # (MILIS) NODE COMMUNICATION WILL DROP IF TIMEOUT IS PASSED
+      - ENVIRONMENT_TYPE=PROD                   # TEST / DEV / PROD
     depends_on:
       - exareme-keystore
     deploy:

diff --git a/Federated-Deployment/Compose-Files/docker-compose-worker.yml b/Federated-Deployment/Compose-Files/docker-compose-worker.yml
@@ -30,8 +30,9 @@ services:
       - CONSULURL=${EXAREME_KEYSTORE}
       - NODE_NAME=${FEDERATION_NODE}
       - FEDERATION_ROLE=${FEDERATION_ROLE}
-      - ENVIRONMENT_TYPE=PROD     #TEST / DEV / PROD
       - TEMP_FILES_CLEANUP_TIME=30
+      - NODE_COMMUNICATION_TIMEOUT=30000        # (MILIS) NODE COMMUNICATION WILL DROP IF TIMEOUT IS PASSED
+      - ENVIRONMENT_TYPE=PROD                   # TEST / DEV / PROD
     deploy:
       restart_policy:
         condition: on-failure

diff --git a/Local-Deployment/docker-compose-master.yml b/Local-Deployment/docker-compose-master.yml
@@ -48,8 +48,9 @@ services:
       - CONSULURL=${EXAREME_KEYSTORE}
       - FEDERATION_ROLE=${FEDERATION_ROLE}
       - NODE_NAME=${FEDERATION_NODE}
-      - ENVIRONMENT_TYPE=PROD   # TEST / DEV / PROD
       - TEMP_FILES_CLEANUP_TIME=30
+      - NODE_COMMUNICATION_TIMEOUT=30000        # (MILIS) NODE COMMUNICATION WILL DROP IF TIMEOUT IS PASSED
+      - ENVIRONMENT_TYPE=PROD                   # TEST / DEV / PROD
     depends_on:
       - exareme-keystore
     deploy: