Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated card component to show all tags #49

Merged
merged 1 commit into from
May 27, 2024
Merged

Updated card component to show all tags #49

merged 1 commit into from
May 27, 2024

Conversation

dvdlite
Copy link
Contributor

@dvdlite dvdlite commented May 26, 2024

Thank you for creating this excellent starter! I have been using eleventy-excellent to build out my own site.

I found when I added multiple tags for my posts, only the first one was showing up for the user.

The fix below updates the card component to show all of the tags instead.

An "IF" statement provides for the exclusion of "administrative" tags, such as "posts" or "feature" while still publishing any tags meant to be displayed to the user.

Thanks!

Copy link

netlify bot commented May 26, 2024

Deploy Preview for eleventy-excellent ready!

Name Link
🔨 Latest commit feb3b72
🔍 Latest deploy log https://app.netlify.com/sites/eleventy-excellent/deploys/6653af5ccade9600082afe0f
😎 Deploy Preview https://deploy-preview-49--eleventy-excellent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@madrilene madrilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this was intentional, I did not want the cards to get cluttered. But it might be a little restrictive / not intuitive. I'll merge this in, and make some small adjustments. Thank you! :)

@madrilene madrilene merged commit 9ccd577 into madrilene:main May 27, 2024
4 checks passed
@dvdlite dvdlite deleted the multi-tag branch May 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants