Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VS2022 on ARM64 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ktos
Copy link

@ktos ktos commented Sep 6, 2024

Hi,
since Windows on ARM and VS2022 on ARM are now more in mainstream, it could be nice to add support. I tried and it was easy :) Apart from ProductArchitecture in the manifest, the build tools and SDK version have been bumped for ARM64 support.

I have been using my build of this extension for some time and it seems to be working properly.

Fixes #98

@@ -119,10 +119,10 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.SDK">
<Version>17.0.0-previews-4-31709-430</Version>
<Version>17.7.37357</Version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be 17.0 to ensure it works correctly on all version of VS 2022

@madskristensen
Copy link
Owner

Thanks for the PR, adding ARM is a great addition

@ktos
Copy link
Author

ktos commented Sep 12, 2024

Unfortunately, with 17.0.0-preview.4 there is no possibility to compile VSIX, as there is an error in manifest validation (there is no possibility for arm64 in enumeration):

1>VSSDK : error VSSDK1062: Schema validation error for 'E:\proj2\OpenCommandLine\src\OpenCommandLine\obj\Release\extension.vsixmanifest'. The 'http://schemas.microsoft.com/developer/vsx-schema/2011:ProductArchitecture' element is invalid - The value 'arm64' is invalid according to its datatype 'http://schemas.microsoft.com/developer/vsx-schema/2011:ProductArchitecture' - The Enumeration constraint failed.

It seems that the lowest version on which it builds is 17.5.

Second question: I've added InstallationTarget with Id of Microsoft.VisualStudio.Community, while the original is with Microsoft.VisualStudio.Pro – which one should be there for maximum compatibility?

<InstallationTarget Version="[17.0,18.0)" Id="Microsoft.VisualStudio.Community">
    <ProductArchitecture>arm64</ProductArchitecture>
</InstallationTarget>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio ARM Support
2 participants