Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI setup #5

Merged
merged 16 commits into from
Aug 31, 2021
Merged

Fix CI setup #5

merged 16 commits into from
Aug 31, 2021

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Aug 29, 2021

Transitions to GitHub Actions, albeit with the Travis CI setup kept in repo for posterity because they have much better support for older macOS versions. Replaces SSheldon/rust-objc#99.

Also changes GNUStep setup with commits from 8fc644a and SSheldon/rust-objc-foundation#6.

Had to pull in SSheldon/rust-objc-exception#8 and SSheldon/rust-objc-exception#10 (which I intended to do anyways, so it's fine) to fix various compilation issues.

- Enable caching
- Move things out of script files, and into the .travis.yml file
- Use "jobs" key, so that we can name each job
@madsmtm madsmtm added the bug Something isn't working label Aug 29, 2021
@madsmtm madsmtm force-pushed the cleanup-ci branch 4 times, most recently from 80efa16 to e66f48b Compare August 31, 2021 13:44
To fix cross compile issues (and also, it's faster to call objc_retain directly instead of using a selector)
Note: The function was also UB before (`RustObjCExceptionThrow` would need to be marked with `C-unwind`)
@madsmtm madsmtm force-pushed the cleanup-ci branch 3 times, most recently from b1c0b17 to f61e86e Compare August 31, 2021 15:14
madsmtm and others added 6 commits August 31, 2021 17:16
They have wider OS support than GitHub Actions, but they also give less free build minutes

Also fixes the iOS tests
The linker is smart enough to figure out that we are not using
any symbols from the Foundation library, and elides the request to
link it. To circumvent this, we define a (unused) function referencing
the symbol for NSObject
I've used up my free credits and getting MacOS credits were more expensive than i thought
@madsmtm madsmtm merged commit d343048 into master Aug 31, 2021
@madsmtm madsmtm deleted the cleanup-ci branch August 31, 2021 15:36
@madsmtm madsmtm mentioned this pull request Sep 5, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants