Update dependencies, Xcode version and minimum deployment target #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions supported by Rust was updated in rust-lang/rust#104385 to: - macOS: 10.12 Sierra - iOS: 10.0 - tvOS: 10.0 - watchOS: 5.0 Additionally, the armv7-apple-ios target was removed. Finally, since v1.0.84 of `cc` (has been yanked, but 1.0.85 will include it as well), there is much better support for specifying the deployment target for Apple targets, so I've removed the corresponding code from objc-sys.
madsmtm
added
enhancement
madsmtm
force-pushed
the
update
branch
3 times, most recently
from
bfd09a5
to
1f241be
Compare
madsmtm
commented
Nov 23, 2023
Comment on lines
+13
to
+14
| pop {r7, lr} | ||
| b _objc_retainAutoreleasedReturnValue |
There was a problem hiding this comment.
I think the fast autoreleasing may have been broken by this change on armv7s-apple-ios :(.
Unsure how to fix that?
Comment on lines
+304
to
+311
| | / declare_class!( | ||
| | | struct CustomObject; | ||
| | | | ||
| | | unsafe impl ClassType for CustomObject { | ||
| ... | | ||
| | | } | ||
| | | ); | ||
| | |_^ the trait `MessageReceiver` is not implemented for `CustomObject` |
There was a problem hiding this comment.
I find that the compiler is often changing between these two, unfortunately we've gotten the worse end of the stick currently.
| @@ -61,7 +61,7 @@ unstable-exception = ["cc"] | |||
| unstable-docsrs = [] | |||
|
|
|||
| [build-dependencies] | |||
| cc = { version = "1", optional = true } | |||
| cc = { version = "1.0.80", optional = true } | |||
There was a problem hiding this comment.
This should be 1.0.84, but that was yanked, so we'll just suggest a high value for now.
madsmtm
force-pushed
the
update
branch
2 times, most recently
from
2dbf3e2
to
041c030
Compare
Previously, we were calling `sel!` before the inner expression, which increases stack pressure because the compiler doesn't know it's allowed to defer loading the selector until just before it needs it.
I had to modify the struct/typedef code a bit, since clang now does those differently.
And make it more visible in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.