Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move objc2_exception into objc2::exception #57

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Move objc2_exception into objc2::exception #57

merged 3 commits into from
Nov 2, 2021

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Oct 31, 2021

objc2 needs a build script anyways, so there's no longer a good reason to keep objc2_exception out of objc2.

@madsmtm
Move objc2_exception into objc2::exception
8d87a8d
@madsmtm
Add catch_all feature, allowing freestanding usage of catch
12ac1c1 
Otherwise the user would be forced to catch all `msg_send!`s, while they may only have wanted to catch them in a specific place.
@madsmtm
Make objc2::exception throw and catch a bit safer
ff865df
@madsmtm madsmtm added the enhancement New feature or request label Oct 31, 2021
@madsmtm
Copy link
Owner Author

madsmtm commented Oct 31, 2021

See also #39 (comment)

@madsmtm madsmtm merged commit ed8f828 into master Nov 2, 2021
@madsmtm madsmtm deleted the exception-merge branch November 2, 2021 13:10
@madsmtm madsmtm mentioned this pull request Nov 2, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madsmtm