Fix Send and Sync implementations on Id and WeakId
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comments in the code for reasoning. The impl for `Id<T, Shared>` is the same as `Arc<T>` and the impl for `Id<T, Owned>` is the same as `Box<T>`.
The implementations follow the same reasoning as `Id<T, Shared>`, since you can upgrade `WeakId` to `Id<T, Shared>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in the code for reasoning.
The impl for
Id<T, Shared>is the same asArc<T>, the impl forId<T, Owned>is the same asBox<T>and the impl forWeakIdis the same asId<T, Shared>(because you can get the latter from the former).See this blog post by
nyanpasu64for more information on this.Replaces SSheldon/rust-objc-id#8.