-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implementation for node v21 #7
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried this in prod at my company and it works just fine! |
mafintosh
reviewed
Dec 21, 2023
index.js
Outdated
@@ -11,9 +11,9 @@ function getStateLength (state) { | |||
// Since node 6.3.0 state.buffer is a BufferList not an array | |||
if (state.buffer.head) { | |||
return state.buffer.head.data.length | |||
} else if (state.buffer[0]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (state.buffer.length > 0 && state.buffer[0])
Thanks, added a comment, otherwise LGTM |
[no-changelog-required]
Any ETA on when this will be merged/released at all? |
Landed in master |
1.0.2 |
confused-moniker
added a commit
to IGUHealth/IGUHealth
that referenced
this pull request
May 16, 2024
@aws/crypto has Dep on Duplexify which uses stream-shift library. This broke on latest Node ver the following bumps dep with fix see issue bellow: mafintosh/stream-shift#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #8. Fixes #6.
This fixes support for the latest nodejs version (node 21). Before this change, the tests failed with this kind of message:
Node made some major changes to the
_readableState
object for performance here: https://github.com/nodejs/node/pull/50341/files#diff-040c1f5a53844e600d40b33c4624f1fe39fcf2f8d62c76ca3fc5ea5442231469 which broke this package's inspection.buffer[0]
is no longer always present, but if it is, it is an array who's.length
we can use.See tests passing here: gadget-inc#2