#131 fix incompatibility with remote storage #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce flag Remote Storage implementation uses a caching mechanism incompatible with the cron service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Background
Fixes #131
When the Remote Storage implementation for AWS S3 is enabled, the module sets a preference for maintenance mode to use the remote filesystem (https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/RemoteStorage/etc/di.xml#L77-L80). The implementation uses a caching mechanism that results in the cron service never coming out of maintenance mode. The FileSystem object detects the maintenance flag being written, but then continues to use the cache of the file's existence (https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/RemoteStorage/Driver/Adapter/CachedAdapter.php#L139-L143). The only way to bring the cron service out of maintenance mode is to restart it
This change adds a preference to force the maintenance flag to be written using the standard filesystem implementation. A shared var dir mount is current practice for Commerce Cloud and a standard pattern for other clustered environments.
Testing
Start the cron service and observe it running without issue.
Enable maintenance mode.
Overserve the cron service pausing during maintenance mode.
Disable maintenance mode.
Observe the cron service resume.