Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined array key "parenthesis_opener" #72

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

fballiano
Copy link
Contributor

Running phpcs on openmage generates:

FILE: /Users/fab/Projects/openmage/lib/Varien/Filter/Template/Tokenizer/Variable.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: Undefined array key "parenthesis_opener" in
   |       | /Users/fab/Projects/openmage/vendor/magento-ecg/coding-standard/Ecg/Sniffs/Performance/LoopSniff.php on line 73
   |       | The error originated in the Ecg.Performance.Loop sniff on line 73. (Internal.Exception)
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

(it actually generates many of the same error lines).

This PR fixes it.

Fixes #70

@fballiano
Copy link
Contributor Author

@alexkaranda could you check this one please? in openmage we can't use ECG in workflows because of this error. thank you!

@alexkaranda alexkaranda merged commit 3fbd3eb into magento-ecg:master Aug 30, 2024
@fballiano fballiano deleted the patch-1 branch August 30, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error fo do...while
2 participants