Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Conversation

adam-paterson
Copy link
Contributor

@adam-paterson adam-paterson commented Feb 6, 2018

Provides support for selection_can_change_qty during import and export

Description

Adds bundle selection properties for use during import and export.

Fixed Issues (if relevant)

  1. BundleImportExport is missing selection_can_change_qty magento/magento2#9342 (BundleImportExport is missing selection_can_change_qty #41 )

Manual testing scenarios

  1. Create Simple products to assign to bundle.
  2. Create Bundled products and assign simples as options.
  3. Export via Import/Export. {{bundle_values}} column should have a property for {{can_change_qty}} which matches the value in for the option in the admin.
  4. Change the value of {{can_change_qty}} and import using the Add/Replace method. Bundle option should change the "User Defined" checkbox in the admin.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Contributor

dmanners commented Feb 7, 2018

Hey @adam-paterson thanks for this. The code looks ok for me at the moment but I see there are a few failing unit and integration tests in the travis build.

Would you be able to have a look at these?

Thanks

@adam-paterson adam-paterson force-pushed the MAGETWO-70390-selection-can-change-qty branch from 046b29b to ac97d6a Compare March 2, 2018 11:26
@adam-paterson adam-paterson force-pushed the MAGETWO-70390-selection-can-change-qty branch from ac97d6a to bac22db Compare March 2, 2018 11:29
@magento-engcom-team
Copy link
Contributor

@adam-paterson thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@adam-paterson
Copy link
Contributor Author

@magento-engcom-team Accepted 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants