Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

magento-engcom/import-export-improvements#44: Update the sample customer csv #110

Merged
merged 1 commit into from
Jul 18, 2018
Merged

magento-engcom/import-export-improvements#44: Update the sample customer csv #110

merged 1 commit into from
Jul 18, 2018

Conversation

dmanners
Copy link
Contributor

Description

  • remove the columns reward_update_notification and reward_warning_notification
  • these attributes are no longer valid but have still been in the sample customer.csv
  • with this change you can now download the sample customer csv and import it directly without error

Fixed Issues (if relevant)

  1. Importing 'Customers Main File' #44: Importing 'Customers Main File'

Manual testing scenarios

  1. Go to 'System' > 'Data Transfer' > 'Import'
  2. Select 'Customers Main File' as 'Entity Type'
  3. Click on 'Download Sample File' link
  4. Select the file downloaded to import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
magento-engcom#44: update Customer sample CSV
4ba2c46 
 - update the sample csv for customer to remove columns reward_update_notification and reward_warning_notification
 - after this PR is merged you will be able to download the sample customer csv and import it directly without getting an error message
@sidolov sidolov self-requested a review July 12, 2018 12:48
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 12, 2018
@magento-engcom-team magento-engcom-team merged commit 4ba2c46 into magento-engcom:2.3-develop Jul 18, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 18, 2018
ENGCOM-2301: #44: Update the sample customer csv #110
a3e285f
@dmanners dmanners mentioned this pull request Jul 23, 2018
Closed
alexeyfirebear added a commit to firebearstudio/magento2-import-export-sample-files that referenced this pull request Apr 11, 2019
@alexeyfirebear
Contained irrelevant attributes
c3cba39 
Contained irrelevant attributes that resulted in the errors: magento-engcom/import-export-improvements#110
alexeyfirebear added a commit to firebearstudio/magento2-import-export-sample-files that referenced this pull request Apr 11, 2019
@alexeyfirebear
Updated XLSX for customers main
802d8f0 
previous sample contained irrelevant attributes: magento-engcom/import-export-improvements#110
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
2.3-develop Component: ImportExport
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanners @sidolov @magento-engcom-team