Add missed $searchCriteriaSearch property

[thicolares]

Description (*)

• Add missed $searchCriteriaSearch property
• Analyse against phpstan returned ""[OK] No errors"

Fixed Issues (if relevant)

1. Clean up Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/TierPriceTest #127: Clean up Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/TierPriceTest

Manual testing scenarios (*)

1. Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/TierPriceTest.php

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[dmanners]

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

[thicolares]

Ok! I am glad to help

[dmanners]

I think looking at it's usage we do not need this as a call variable but could make it local to the method only. Would you be up for making this change and then validating the phpstan and phpunit test again?

[thicolares]

Sure! Besides $searchCriteriaSearch, I believe I should do the same for $objectManagerHelper and $searchCriteriaBuilder -- both are also only local and not instantiated via dependency injection.

[magento-engcom-team]

@thicolares thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[dmanners]

Thank you for your effort here. As we are focusing import work on the async-import project we will be closing this project for now.

[ghost]

Hi @thicolares, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.