Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APCu to 'always installed' list #8864

Closed
wants to merge 1 commit into from

Conversation

fredden
Copy link
Member

@fredden fredden commented Apr 11, 2021

Purpose of this pull request

This pull request adds APCu to the list of PHP extensions that are always installed on Magento Cloud. This is a feature request that is being discussed in magento/ece-tools#795

Affected DevDocs pages

@BarnyShergold
Copy link
Contributor

@fredden - There hasn't been any movement on this since the Draft was created nearly 3 weeks ago - please can we have an update on progress?

@fredden
Copy link
Member Author

fredden commented Apr 27, 2021

This is waiting on an infrastructure change that only Adobe can make. magento/ece-tools#795 (comment) I've enquired with Adobe staff on the Magento Community Engineering Slack workspace and they've confirmed that Adobe is unwilling to grant access to the relevant repositories for me to help further.

I don't envisage the changes here needing any further work (except resolving conflicts), but it doesn't make sense to merge this before the infrastructure change has been made. You're welcome to click the 'Ready for review' button here if you'd like.

@dobooth
Copy link
Contributor

dobooth commented May 4, 2021

We want to encourage doc contributions in tandem with code contributions. Getting things through the code base is slightly more complex than devdocs, so I think we can be patient with this draft. Thanks for the work.

@dobooth
Copy link
Contributor

dobooth commented Aug 26, 2021

@fredden I will contradict myself and vote to close this for now. It's a simple enough reopen it when the ece-tools PR goes through.

@dobooth dobooth closed this Aug 26, 2021
@ghost
Copy link

ghost commented Aug 26, 2021

Hi @fredden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Fisheye partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants