Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders #1009

Closed
TomashKhamlai opened this issue Oct 15, 2019 · 2 comments · Fixed by #1028
Closed

[Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders #1009

TomashKhamlai opened this issue Oct 15, 2019 · 2 comments · Fixed by #1028
Assignees
@atwixfirster
Labels
Component: SalesGraphQl Fixed in 2.3.x good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.4

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Oct 15, 2019 •
edited
Loading

Description:

Cover with API-functional tests:

graphql-ce/app/code/Magento/SalesGraphQl/Model/Resolver/Orders.php

Line 48 in 746038e

throw new GraphQlAuthorizationException(__('The current customer isn\'t authorized.'));

TestCases:

 - testQueryOrdersAsGuest

Examples:

Magento\GraphQl\Customer
Magento\GraphQl\Quote\Customer

Guide:

Graphql Functional Testing
@TomashKhamlai TomashKhamlai changed the title Cover exception in SalesGraphQl\Model\Resolver\Orders [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders Oct 15, 2019
@atwixfirster atwixfirster self-assigned this Oct 16, 2019
atwixfirster added a commit that referenced this issue Oct 23, 2019
@atwixfirster
#1009: [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver…
3541938 
…\Orders
@atwixfirster atwixfirster mentioned this issue Oct 23, 2019
Merged
4 tasks
@atwixfirster
Copy link
Contributor

Pull request: #1028

atwixfirster added a commit that referenced this issue Oct 23, 2019
@atwixfirster
#1009: [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver…
d035bc6 
…\Orders
atwixfirster added a commit that referenced this issue Oct 23, 2019
@atwixfirster
#1009: [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver…
7b345f0 
…\Orders
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Oct 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your report.
The issue has been fixed in #1028 by @atwixfirster in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Component: SalesGraphQl Fixed in 2.3.x good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.4
4 participants
@TomashKhamlai @atwixfirster @lenaorobei @magento-engcom-team