Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Static Test which would prevent adding new code to MSI without Strict Typing #206

Closed
maghamed opened this issue Nov 18, 2017 · 0 comments
Assignees

Comments

@maghamed
Copy link
Contributor

All the new code suppose to rely on

declare(strict_types=1);

Currently, we have a Static test suite with
Magento\Test\Php\LiveCodeTest test
which makes all the live code static checks like code style, code complexity, copy paste detecting
and all that done just for the modified code being delivering to mainline.

We need to add a similar check and test whether modified file which supposed to be pushed into the branch contains declare(strict_types=1);

Also, it's needed to add a whitelist to make this check just for MSI modules (currently modules having Inventory prefix), so you can specify the names of the modules which supposed to be check.

And blacklist where a developer could specify filenames for which the check could be skipped, for example, because it's a legacy code which requires refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants