You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have a Static test suite with Magento\Test\Php\LiveCodeTest test
which makes all the live code static checks like code style, code complexity, copy paste detecting
and all that done just for the modified code being delivering to mainline.
We need to add a similar check and test whether modified file which supposed to be pushed into the branch contains declare(strict_types=1);
Also, it's needed to add a whitelist to make this check just for MSI modules (currently modules having Inventory prefix), so you can specify the names of the modules which supposed to be check.
And blacklist where a developer could specify filenames for which the check could be skipped, for example, because it's a legacy code which requires refactoring
The text was updated successfully, but these errors were encountered:
All the new code suppose to rely on
Currently, we have a Static test suite with
Magento\Test\Php\LiveCodeTest
testwhich makes all the live code static checks like code style, code complexity, copy paste detecting
and all that done just for the modified code being delivering to mainline.
We need to add a similar check and test whether modified file which supposed to be pushed into the branch contains
declare(strict_types=1);
Also, it's needed to add a whitelist to make this check just for MSI modules (currently modules having Inventory prefix), so you can specify the names of the modules which supposed to be check.
And blacklist where a developer could specify filenames for which the check could be skipped, for example, because it's a legacy code which requires refactoring
The text was updated successfully, but these errors were encountered: