MSI magento-engcom/magento#91: #106
Conversation
| @@ -22,6 +22,19 @@ | |||
| public function saveIndex(IndexName $indexName, \Traversable $documents); | |||
|
|
|||
| /** | |||
| * Create the index i not exits or remove sku list from the index to rebuild | |||
There was a problem hiding this comment.
why method, which name is cleanUp creates a table?
| * @param string $connectionName | ||
| * @return void | ||
| */ | ||
| public function cleanUp( |
There was a problem hiding this comment.
let's rename the method into cleanIndex
as we have saveIndex and deleteIndex methods here
| * Returns all assigned stock ids by given sources item ids. | ||
| * | ||
| * @param int[] $sourceItemIds | ||
| * @return int[] List of stock id to sku1,sku2 assignment |
There was a problem hiding this comment.
PHP Annotation for type is wrong, because it's not an array of int[]
it's an array of arrays , like
[1] => ['sku-1', 'sku-2', sku-3],
[2] => ['sku-1']
maybe it's better to use an object to keep the contract of result
| /** | ||
| * Returns all assigned stock ids by given sources ids | ||
| */ | ||
| class GetDeltaReindexData |
There was a problem hiding this comment.
let's re-name Delta -> Partial
| @@ -79,7 +88,7 @@ public function __construct( | |||
| */ | |||
| public function executeFull() | |||
| { | |||
| $stockIds = $this->getAssignedStockIds->execute([]); | |||
| $stockIds = $this->getFullReindexData->execute(); | |||
There was a problem hiding this comment.
I see a bug in executeFull indexing implementation.
Currently it looks like
public function executeFull()
{
$stockIds = $this->getFullReindexData->execute();
foreach ($stockIds as $stockId) {
$mainIndexName = $this->indexNameBuilder
->setIndexId(StockItemIndexerInterface::INDEXER_ID)
->addDimension('stock_', $stockId)
->setAlias(Alias::ALIAS_MAIN)
->build();
$this->indexStructure->create($mainIndexName);
$replicaIndexName = $this->indexNameBuilder
->setIndexId(StockItemIndexerInterface::INDEXER_ID)
->addDimension('stock_', $stockId)
->setAlias(Alias::ALIAS_REPLICA)
->build();
$this->indexStructure->create($replicaIndexName);
But IndexStructure::create works like
public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION)
{
$connection = $this->resourceConnection->getConnection($connectionName);
$tableName = $this->indexNameResolver->resolveName($indexName);
if ($connection->isTableExists($tableName)) {
$connection->truncateTable($tableName);
return;
}
$this->createTable($connection, $tableName);
So, it Truncates table if it exists.
The main reason to use _Main table and _Replica was to support 0 downtime.
And make a re-indexation on _Replica table while _Main table is being accessed and after re-indexation to rename _Replica -> _Main.
But currently at the beggining of the re-indexation we just truncate both of the tables
| $connection = $this->resourceConnection->getConnection($connectionName); | ||
| $tableName = $this->indexNameResolver->resolveName($indexName); | ||
| if ($connection->isTableExists($tableName) === false) { | ||
| $this->createTable($connection, $tableName); |
There was a problem hiding this comment.
I expect you will get Fatal Error at this line
[Arrows] MC-40738: [MSI] “Add to Compare” function is not available if a Product is unavailable in the “Default Source” or unassigned from it.
#Performance Optimizing for the Indexing Mview Part #91