-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1451 avoid fading assign sources listing when advanced inventory manage stock being changed #1453
Merged
maghamed
merged 12 commits into
2.3-develop
from
MSI-1451-avoid-fading-assign-sources-listing-when-advanced-inventory-manage-stock-being-changed
Sep 18, 2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manage stock being changed
…nto MSI-1451-avoid-fading-assign-sources-listing-when-advanced-inventory-manage-stock-being-changed
@VitaliyBoyko Hi Vitaliy, may you please recheck your PR
|
…ck unexpected behaviour
Hi @smoskaluk |
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
Hi @VitaliyBoyko! |
Thanks @smoskaluk |
@smoskaluk I've hidden sources tab in single stock mode instead of hiding source button and dynamic rows. |
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
maghamed
approved these changes
Sep 18, 2018
maghamed
deleted the
MSI-1451-avoid-fading-assign-sources-listing-when-advanced-inventory-manage-stock-being-changed
branch
March 20, 2019 15:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)
Avoid fading assign sources listing when advanced inventory manage stock being changed
Steps to reproduce
Expected result
Assign sources dynamic rows should be visible, inputs related to stock should be disabled.
Actual result
assign sources dynamic rows will fade.