Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1451 avoid fading assign sources listing when advanced inventory manage stock being changed #1453

Conversation

VitaliyBoyko
Copy link
Contributor

Fixed Issues (if relevant)

  1. Avoid fading assign sources listing when advanced inventory manage stock being changed #1451:
    Avoid fading assign sources listing when advanced inventory manage stock being changed

Steps to reproduce

  1. Open product form
  2. Click on "advanced inventory"
  3. Set manage stock to "No" and click "Done"

Expected result

Assign sources dynamic rows should be visible, inputs related to stock should be disabled.

Actual result

assign sources dynamic rows will fade.

…nto MSI-1451-avoid-fading-assign-sources-listing-when-advanced-inventory-manage-stock-being-changed
@smoskaluk
Copy link

@VitaliyBoyko Hi Vitaliy, may you please recheck your PR

  1. Problem - in single stock mode on the product page in admin present "Sources' tab
  2. Problem - after creating custom source and then creating simple product and assign to default and custom sources - after save product get 'Mange stock' = No in 'Advanced inventory' (despite that 'Use config settings' is checked)
    image

@VitaliyBoyko
Copy link
Contributor Author

Hi @smoskaluk
All mentioned issues have been fixed. Thank you!

…listing-when-advanced-inventory-manage-stock-being-changed
Vitaliy added 2 commits July 27, 2018 09:10
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
@smoskaluk
Copy link

Hi @VitaliyBoyko!
in single stock mode on the product page in admin "Sources' tab is present again
image

@VitaliyBoyko
Copy link
Contributor Author

Thanks @smoskaluk
Gonna check it.

@VitaliyBoyko
Copy link
Contributor Author

@smoskaluk I've hidden sources tab in single stock mode instead of hiding source button and dynamic rows.

…listing-when-advanced-inventory-manage-stock-being-changed
Vitaliy added 3 commits August 2, 2018 11:47
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
…listing-when-advanced-inventory-manage-stock-being-changed
@maghamed maghamed merged commit 82d199c into 2.3-develop Sep 18, 2018
@maghamed maghamed deleted the MSI-1451-avoid-fading-assign-sources-listing-when-advanced-inventory-manage-stock-being-changed branch March 20, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants