Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSI-1866: Changes to Source Selection Service Contracts #1986

Merged
merged 10 commits into from
Jan 18, 2019
Merged

MSI-1866: Changes to Source Selection Service Contracts #1986

merged 10 commits into from
Jan 18, 2019

Conversation

maghamed
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento-engcom/msi#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@maghamed maghamed added this to the MSI Part III milestone Jan 18, 2019
@maghamed
Copy link
Contributor Author

@phoenix128 could you please review and merge

@maghamed
Copy link
Contributor Author

maghamed commented Jan 18, 2019 •
edited
Loading

Jenkins UR basic green:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12284/

UR acceptance:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12285/

Existing PR
https://m2build.devops.magento.com/job/Existing-PR-Tests/11270/

Existing PR develop
https://m2build.devops.magento.com/job/Existing-PR-Tests/11271/

@maghamed
Copy link
Contributor Author

all Jenkins tests are re-run

@maghamed
Copy link
Contributor Author

Jenkins UR basic_green:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12286/

@phoenix128 phoenix128 merged commit f630dbd into distance-based-source-selection-algorythm Jan 18, 2019
@ghost
Copy link

ghost commented Jan 18, 2019

Hi @maghamed, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ishakhsuvarov ishakhsuvarov deleted the MSI-1866 branch June 19, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoenix128 phoenix128 Awaiting requested review from phoenix128

Assignees

@phoenix128 phoenix128

Labels
None yet
Projects
None yet
Milestone
MSI Part III
Development

Successfully merging this pull request may close these issues.
2 participants
@maghamed @phoenix128