Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken modularity in InventoryCatalog #215

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Broken modularity in InventoryCatalog #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/code/Magento/InventoryCatalog/etc/adminhtml/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<!-- Stock delete button -->
<type name="Magento\InventoryCatalog\Ui\Component\Control\Stock\DeleteButton">
<arguments>
<argument name="deleteButton" xsi:type="object">Magento\Inventory\Ui\Component\Control\Stock\DeleteButton</argument>
</arguments>
</type>
<!-- Product form configurations -->
<virtualType name="Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\Pool">
<arguments>
Expand Down
2 changes: 1 addition & 1 deletion .../Component/Control/Stock/DeleteButton.php → .../Component/Control/Stock/DeleteButton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
declare(strict_types=1);

namespace Magento\InventoryCatalog\Ui\Component\Control\Stock;
namespace Magento\InventorySales\Ui\Component\Control\Stock;

use Magento\Backend\Ui\Component\Control\DeleteButton as StockDeleteButton;
use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
Expand Down
15 changes: 15 additions & 0 deletions app/code/Magento/InventorySales/etc/adminhtml/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
<!-- Stock delete button -->
<type name="Magento\InventorySales\Ui\Component\Control\Stock\DeleteButton">
<arguments>
<argument name="deleteButton" xsi:type="object">Magento\Inventory\Ui\Component\Control\Stock\DeleteButton</argument>
</arguments>
</type>
</config>
5 changes: 5 additions & 0 deletions app/code/Magento/InventorySales/view/adminhtml/ui_component/inventory_stock_form.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
*/
-->
<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
<settings>
<buttons>
<button name="delete" class="Magento\InventorySales\Ui\Component\Control\Stock\DeleteButton"/>
</buttons>
</settings>
<fieldset name="sales_channels" sortOrder="30">
<settings>
<label translate="true">Sales Channels</label>
Expand Down