Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#199 - Assign main website to default stock #221

Merged
merged 4 commits into from
Nov 24, 2017

Conversation

sinisa86
Copy link
Contributor

Implemented assign of Main Website to Default stock

Description

We have already plugin which serves for creation of sales channel between created website and default stock (\Magento\InventorySales\Observer\Website\AssignWebsiteToDefaultStock).

However, because core of Magento doesn't use API for website creation, we're not able to plug in there and associate it with Default Stock.

In order to fix the issue, we have to create data install script which adds missing relation between Main website and Default stock.
(reference: https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Store/Setup/InstallSchema.php#L258)

Fixed Issues (if relevant)

#199: Assign main website to default stock

Manual testing scenarios

  1. Run fresh install of Magento within develop branch
  2. Check if inventory_stock_sales_channel table contains relation between Main Website (base) and Default stock (1).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Copy link
Contributor

@maghamed maghamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good execution @sinisa86 !
Well Done!

-- Update dependencies in composer.json
@naydav naydav merged commit d33c139 into develop Nov 24, 2017
@maghamed maghamed deleted the 199_assign_main_website_to_default_stock branch December 11, 2018 18:16
magento-devops-reposync-svc pushed a commit that referenced this pull request May 18, 2022
…ry-3287

[Imported] Allow higher versions of magento/inventory-composer-installer to be installed in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants